Re: [PATCH] usbip: vhci-hcd: make vhci_hc_driver const

From	Shuah Khan <shuah@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usbip: vhci-hcd: make vhci_hc_driver const
Date	2017-08-30 19:30 +0200
Message-ID	<ukeYp-2MD-3@gated-at.bofh.it> (permalink)
References	<ukaLa-8rd-67@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/30/2017 06:52 AM, Bhumika Goyal wrote:
> Make this const as it is not modified anywhere.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/usb/usbip/vhci_hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index c747623..11b9a22 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1274,7 +1274,7 @@ static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev,
>  	return 0;
>  }
>  
> -static struct hc_driver vhci_hc_driver = {
> +static const struct hc_driver vhci_hc_driver = {
>  	.description	= driver_name,
>  	.product_desc	= driver_desc,
>  	.hcd_priv_size	= sizeof(struct vhci_hcd),
> 

Looks good to me.

Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usbip: vhci-hcd: make vhci_hc_driver const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-30 15:00 +0200
  Re: [PATCH] usbip: vhci-hcd: make vhci_hc_driver const Shuah Khan <shuah@kernel.org> - 2017-08-30 19:30 +0200

csiph-web