Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723394

Re: [PATCH v2 1/2] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for LAN8710

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Mon, Aug 28, 2017 at 09:32:42AM +0300, Stefan Mavrodiev wrote:
> From revision J the board uses new phy chip LAN8710. Compared
> with RTL8201, RA17 pin is TXERR. It has pullup which causes phy
> not to work. To fix this PA17 is muxed with GMAC function. This
> makes the pin output-low.
> 
> This patch is compatible with earlier board revisions, since this
> pin wasn't connected to phy.
> 
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
> ---
>  arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
> index 0b7403e..cb1b081 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
> @@ -102,7 +102,7 @@
>  
>  &gmac {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&gmac_pins_mii_a>;
> +	pinctrl-0 = <&gmac_pins_mii_a>,<&gmac_txerr>;
>  	phy = <&phy1>;
>  	phy-mode = "mii";
>  	status = "okay";
> @@ -229,6 +229,11 @@
>  };
>  
>  &pio {
> +	gmac_txerr: gmac_txerr@0 {
> +		pins = "PA17";
> +		function = "gmac";
> +	};
> +

The patch looks fine, I still have one question though.

Can a PHY operate without this signal? My real question is, would it
make sense to mux that pin for all the users, or is it an optional
signal that each board designer can choose to use or not?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] Update board support for A20-OLinuXino-MICRO Stefan Mavrodiev <stefan@olimex.com> - 2017-08-28 08:40 +0200
  [PATCH v2 2/2] ARM: dts: sun7i: Add dts file for A20-OLinuXino-MICRO-eMMC Stefan Mavrodiev <stefan@olimex.com> - 2017-08-28 08:40 +0200
    Re: [PATCH v2 2/2] ARM: dts: sun7i: Add dts file for  A20-OLinuXino-MICRO-eMMC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-30 16:40 +0200
  [PATCH v2 1/2]  ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for LAN8710 Stefan Mavrodiev <stefan@olimex.com> - 2017-08-28 08:40 +0200
    Re: [PATCH v2 1/2]  ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for  LAN8710 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-30 16:40 +0200
      Re: [PATCH v2 1/2] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for  LAN8710 Stefan Mavrodiev <stefan.mavrodiev@gmail.com> - 2017-08-31 07:30 +0200
        Re: [PATCH v2 1/2] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for  LAN8710 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-01 15:10 +0200
    Re: [PATCH v2 1/2]  ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for  LAN8710 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-01 15:10 +0200

csiph-web