[PATCH] drm/i915/opregion: Remove null check before kfree

From	Himanshu Jha <himanshujha199640@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] drm/i915/opregion: Remove null check before kfree
Date	2017-08-30 15:40 +0200
Message-ID	<ukbnR-rR-29@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

kfree on NULL pointer is a no-op and therefore checking is redundant.

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
 drivers/gpu/drm/i915/intel_opregion.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index 98154ef..2427b40 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -830,10 +830,8 @@ void intel_opregion_unregister(struct drm_i915_private *dev_priv)
 		memunmap(opregion->rvda);
 		opregion->rvda = NULL;
 	}
-	if (opregion->vbt_firmware) {
-		kfree(opregion->vbt_firmware);
-		opregion->vbt_firmware = NULL;
-	}
+	kfree(opregion->vbt_firmware);
+	opregion->vbt_firmware = NULL;
 	opregion->header = NULL;
 	opregion->acpi = NULL;
 	opregion->swsci = NULL;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/i915/opregion: Remove null check before kfree Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-30 15:40 +0200
  Re: [PATCH] drm/i915/opregion: Remove null check before kfree Jani Nikula <jani.nikula@linux.intel.com> - 2017-08-31 08:40 +0200

csiph-web