[PATCH] kernfs: checking for IS_ERR() instead of NULL

Path	csiph.com!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[PATCH] kernfs: checking for IS_ERR() instead of NULL
Date	Wed, 30 Aug 2017 16:10:02 +0200
Message-ID	<ukbQS-R3-3@gated-at.bofh.it> (permalink)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-Mailer	git-send-email haha only kidding
User-Agent	NeoMutt/20170609 (1.8.3)
X-Source-IP	aserv0021.oracle.com [141.146.126.233]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	Tejun Heo <tj@kernel.org>, linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, kernel-janitors@vger.kernel.org
X-Original-Date	Wed, 30 Aug 2017 17:04:56 +0300
X-Original-Message-ID	<20170830140456.7n6sfogqb7mvjmrm@mwanda>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1723357

Show key headers only | View raw

The kernfs_get_inode() returns NULL on error, it never returns error
pointers.

Fixes: aa8188253474 ("kernfs: add exportfs operations")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c
index 7c452f4d83e9..95a7c88baed9 100644
--- a/fs/kernfs/mount.c
+++ b/fs/kernfs/mount.c
@@ -99,8 +99,8 @@ static struct inode *kernfs_fh_get_inode(struct super_block *sb,
 		return ERR_PTR(-ESTALE);
 	inode = kernfs_get_inode(sb, kn);
 	kernfs_put(kn);
-	if (IS_ERR(inode))
-		return ERR_CAST(inode);
+	if (!inode)
+		return ERR_PTR(-ESTALE);
 
 	if (generation && inode->i_generation != generation) {
 		/* we didn't find the right inode.. */

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] kernfs: checking for IS_ERR() instead of NULL Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-30 16:10 +0200
  Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL Tejun Heo <tj@kernel.org> - 2017-08-31 02:40 +0200
  Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-31 19:00 +0200
    Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL Jens Axboe <axboe@kernel.dk> - 2017-08-31 22:00 +0200
      Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-01 07:10 +0200
  Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL Jens Axboe <axboe@kernel.dk> - 2017-09-01 16:20 +0200

csiph-web