Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1723329

Re: [PATCH 2/3] iommu: mtk: constify iommu_ops

From Joerg Roedel <joro@8bytes.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] iommu: mtk: constify iommu_ops
Date 2017-08-30 15:20 +0200
Message-ID <ukb4v-li-45@gated-at.bofh.it> (permalink)
References <ujrbj-5ug-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Aug 28, 2017 at 05:42:26PM +0530, Arvind Yadav wrote:
> iommu_ops are not supposed to change at runtime.
> Functions 'iommu_device_set_ops' and 'bus_set_iommu' working with
> const iommu_ops provided by <linux/iommu.h>. So mark the non-const
> structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/iommu/mtk_iommu.c    | 4 ++--
>  drivers/iommu/mtk_iommu_v1.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

This doesn't apply cleanly to the arm/mediatek branch in the iommu-tree.
Please rebase it against that branch and update the subject to:

	iommu/mediatek: Constify iommu_ops

to match the convention used in the iommu-tree and send it again.


Thanks,

	Joerg

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] iommu: mtk: constify iommu_ops Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-28 14:20 +0200
  Re: [PATCH 2/3] iommu: mtk: constify iommu_ops Joerg Roedel <joro@8bytes.org> - 2017-08-30 15:20 +0200

csiph-web