Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1723319

Re: [PATCH] mmc: mmci: constify amba_id

From Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mmc: mmci: constify amba_id
Date 2017-08-30 15:20 +0200
Message-ID <ukb4u-li-17@gated-at.bofh.it> (permalink)
References <uhGRb-2TW-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 23 August 2017 at 18:30, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/mmci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index d1ca2f4..f1f54a8 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -1904,7 +1904,7 @@ static const struct dev_pm_ops mmci_dev_pm_ops = {
>         SET_RUNTIME_PM_OPS(mmci_runtime_suspend, mmci_runtime_resume, NULL)
>  };
>
> -static struct amba_id mmci_ids[] = {
> +static const struct amba_id mmci_ids[] = {
>         {
>                 .id     = 0x00041180,
>                 .mask   = 0xff0fffff,
> --
> 2.7.4
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] mmc: mmci: constify amba_id Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-30 15:20 +0200

csiph-web