Re: [PATCH] mmc: mmci: stop building qcom dml as module

From	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: mmci: stop building qcom dml as module
Date	2017-08-30 14:30 +0200
Message-ID	<ukai6-8hx-21@gated-at.bofh.it> (permalink)
References	<ucX6i-723-9@gated-at.bofh.it> <ugU9Q-4ml-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


>> -#ifdef CONFIG_MMC_QCOM_DML
>> +#if IS_ENABLED(CONFIG_MMC_QCOM_DML)
> 
> Because you change CONFIG_MMC_QCOM_DML beeing a bool instead of
> tristate, then I don't think you need to change this to IS_ENABLED().
> 
> Correct!?
Yep, that's correct Will respin the patch without this change


> 
>>   int dml_hw_init(struct mmci_host *host, struct device_node *np);
>>   void dml_start_xfer(struct mmci_host *host, struct mmc_data *data);
>>   #else
>> --
>> 2.9.3
>>
> 
> Otherwise this looks good to me.
> 
> Kind regards
> Uffe
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: mmci: stop building qcom dml as module Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-08-30 14:30 +0200

csiph-web