Re: [PATCH 0/5] net: mdio-mux: Misc fix

From	Corentin Labbe <clabbe.montjoie@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/5] net: mdio-mux: Misc fix
Date	2017-09-01 10:40 +0200
Message-ID	<ukPEC-1pS-17@gated-at.bofh.it> (permalink)
References	<ukfhM-2SU-13@gated-at.bofh.it> <ukgxb-3Pz-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 30, 2017 at 09:01:19PM +0200, Andrew Lunn wrote:
> On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote:
> > Hello
> > 
> > This patch series fix minor problems found when working on the
> > dwmac-sun8i syscon mdio-mux.
> 
> Hi Corentin
> 
> In geineral, a nice patchset.

Thanks, I will send a v2 with your suggestions.

> 
> Looking at the code, there are a few calls to devm_kfree() which look
> redundant. This one should probably stay:
> 
> 	   	if (r) {
> 			mdiobus_free(cb->mii_bus);
> 			devm_kfree(dev, cb);
> 		} else {
> 
> but i think the others can go.
> 
> Just a suggestion, not a problem if you don't feel like doing this...
> 

I will try but in another serie. For letting more time for test.

Regards

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] net: mdio-mux: Misc fix Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-30 19:50 +0200
  [PATCH 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-30 19:50 +0200
    Re: [PATCH 2/5] net: mdio-mux: Remove unnecessary 'out of memory'  message Andrew Lunn <andrew@lunn.ch> - 2017-08-30 20:50 +0200
  [PATCH 3/5] net: mdio-mux: printing driver version is useless Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-30 20:00 +0200
    Re: [PATCH 3/5] net: mdio-mux: printing driver version is useless Andrew Lunn <andrew@lunn.ch> - 2017-08-30 20:50 +0200
  [PATCH 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-30 20:00 +0200
    Re: [PATCH 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits  registers Andrew Lunn <andrew@lunn.ch> - 2017-08-30 20:50 +0200
  [PATCH 1/5] net: mdio-mux: Fix NULL Comparison style Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-08-30 20:00 +0200
    Re: [PATCH 1/5] net: mdio-mux: Fix NULL Comparison style Andrew Lunn <andrew@lunn.ch> - 2017-08-30 20:50 +0200
  Re: [PATCH 0/5] net: mdio-mux: Misc fix Andrew Lunn <andrew@lunn.ch> - 2017-08-30 21:10 +0200
    Re: [PATCH 0/5] net: mdio-mux: Misc fix Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-01 10:40 +0200

csiph-web