Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance.
Date	2017-09-01 09:30 +0200
Message-ID	<ukOyR-G9-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <uksI2-38N-27@gated-at.bofh.it> <uksRI-3bX-31@gated-at.bofh.it> <ukt1n-3fk-19@gated-at.bofh.it> <ukvZh-52z-47@gated-at.bofh.it> <ukwsi-5u5-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 31, 2017 at 02:00:54PM +0200, Martijn Coenen wrote:
> On Thu, Aug 31, 2017 at 1:32 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > AFAIK people are actively working on fixing that.
> 
> SCHED_DEADLINE was definitely looked at in the past. We certainly
> don't use it on our own devices in Android Oreo, and I am not aware of
> any current plans to use it. But the Android org is big, so I may
> simply not be aware. In either case I'd be happy to support it if
> there is a need for it.
> 
> >
> > I still have to look at the actual patches, but it all sounds very
> > dodgy. Probably won't have time until after LPC.
> 
> Appreciate if you could take a look! In particular I'm curious why
> this approach is considered "dodgy", or "engineered sideways" as
> Thomas pointed out earlier. From what I can tell the reason why we
> want to change task priorities (potentially from a different task) is
> understood. So is the main concern using sched_setscheduler()
> directly, instead of having a prio "modifier" much like rt_mutex has?
> We (and our partners) are using these patches without issues, though
> it does come with the caveat that threads in the binder threadpool
> should not be changing their own priority from userspace for this to
> work correctly (though they shouldn't have been doing that before
> these patches either).
> 
> Either way, it sounds like this discussion will take a bit longer, so
> I will pull out the few unrelated patches from this series and post
> them separately.

I've now applied patches 1, 2, 7, 9, 11, and 12 from this series to my
tree, so feel free to rebase on it for the next round of these patches.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance. Martijn Coenen <maco@android.com> - 2017-08-31 10:10 +0200
  Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio  inheritance. Peter Zijlstra <peterz@infradead.org> - 2017-08-31 10:20 +0200
    Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance. Martijn Coenen <maco@android.com> - 2017-08-31 10:30 +0200
      Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio  inheritance. Peter Zijlstra <peterz@infradead.org> - 2017-08-31 13:40 +0200
        Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio inheritance. Martijn Coenen <maco@android.com> - 2017-08-31 14:10 +0200
          Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio  inheritance. Peter Zijlstra <peterz@infradead.org> - 2017-08-31 14:30 +0200
          Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio  inheritance. Greg KH <gregkh@linuxfoundation.org> - 2017-09-01 09:30 +0200

csiph-web