Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1724436

[PATCH RESEND v2 1/3] tpm2-cmd: Trigger only missing self tests

Show all headers | View raw

tpm2_do_selftest is only used during initialization of the TPM to ensure
that the device functions correctly. Therefore, it is sufficient to request
only missing self tests (parameter full_test=0), not a reexecution of all
self tests, as was done before. This allows for a faster execution of this
command.

Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 drivers/char/tpm/tpm2-cmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
index e1a41b7..8e940a5 100644
--- a/drivers/char/tpm/tpm2-cmd.c
+++ b/drivers/char/tpm/tpm2-cmd.c
@@ -865,7 +865,7 @@ static int tpm2_start_selftest(struct tpm_chip *chip, bool full)
 }
 
 /**
- * tpm2_do_selftest() - run a full self test
+ * tpm2_do_selftest() - ensure that all self tests have passed
  *
  * @chip: TPM chip to use
  *
@@ -886,7 +886,7 @@ static int tpm2_do_selftest(struct tpm_chip *chip)
 
 	loops = jiffies_to_msecs(duration) / delay_msec;
 
-	rc = tpm2_start_selftest(chip, true);
+	rc = tpm2_start_selftest(chip, false);
 	if (rc)
 		return rc;
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND v2 0/3] tpm2-cmd: Improve self test execution Alexander Steffen <Alexander.Steffen@infineon.com> - 2017-08-31 19:20 +0200
  [PATCH RESEND v2 2/3] tpm2-cmd: Use dynamic delay to wait for self test result Alexander Steffen <Alexander.Steffen@infineon.com> - 2017-08-31 19:20 +0200
  [PATCH RESEND v2 1/3] tpm2-cmd: Trigger only missing self tests Alexander Steffen <Alexander.Steffen@infineon.com> - 2017-08-31 19:20 +0200
  Re: [PATCH RESEND v2 0/3] tpm2-cmd: Improve self test execution Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-02 12:20 +0200
  Re: [PATCH RESEND v2 0/3] tpm2-cmd: Improve self test execution Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-06 15:00 +0200
    Re: [PATCH RESEND v2 0/3] tpm2-cmd: Improve self test execution Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-08 12:10 +0200

csiph-web