Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1724464

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

From Randy Dunlap <rdunlap@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] docs: kernel-doc comments are ASCII
Date 2017-08-31 20:00 +0200
Message-ID <ukBUZ-hU-7@gated-at.bofh.it> (permalink)
References (6 earlier) <ukyu5-6Gt-17@gated-at.bofh.it> <ukzTc-7qZ-1@gated-at.bofh.it> <ukAcz-7O1-25@gated-at.bofh.it> <ukAFA-7XG-31@gated-at.bofh.it> <ukBBD-ap-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 08/31/17 10:34, Randy Dunlap wrote:
> On 08/31/17 09:36, Jani Nikula wrote:
>> On Thu, 31 Aug 2017, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>>> On Thu, 31 Aug 2017, Randy Dunlap <rdunlap@infradead.org> wrote:
>>>> On 08/31/17 07:17, Jonathan Corbet wrote:
>>>>> On Thu, 31 Aug 2017 10:56:26 -0300
>>>>> Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
>>>>>
>>>>>> It should have something to do with python version and/or to some
>>>>>> locale info at the system, as neither I or Jon can reproduce it.
>>>>>
>>>>> I can't reproduce it here, but I have certainly seen situations where
>>>>> Python 2 wants to run with the ascii codec by default.
>>>>>
>>>>> Note that the exception happens in our Sphinx extension, not in Sphinx
>>>>> itself.  We've had other non-ascii text in our docs, so I think Sphinx is
>>>>> doing the right thing.  The problem is with our own code.  If I could
>>>>> reproduce it, it shouldn't be too hard to track down - take out that
>>>>> massive "except anything" block and see where it explodes.
>>>>>
>>>>> Randy, which distribution are you running, and are you using their version
>>>>> of Sphinx?
>>>>
>>>> opensuse LEAP 42.2
>>>> Yes, their sphinx 1.3.1.
>>>
>>> What's your LANG setting? I think that's what it boils down to, and
>>> trying to work around non-UTF-8 LANG in both python 2 and 3 compatible
>>> ways.
>>>
>>> The odd thing is that I can reproduce the issue using a small python
>>> snippet, but not through Sphinx.
>>
>> Your original error message suggests your Sphinx actually uses python
>> 3. Can you check that? The clue is that it's the *decode* that fails.
> 
> Where do you see that clue?
> My /usr/bin/python is linked to python2.7:
> 
>> ll /usr/bin/python
> lrwxrwxrwx 1 root root 9 Jun 10 19:59 /usr/bin/python -> python2.7*
> 
>> Does the below patch help? It avoids the implicit ascii decoding due to
>> universal_newlines=True and your LANG setting, and does explicit utf-8
>> decoding instead.
>>
>> Fingers crossed.
> 
> testing now.

Yes, that works for me.  Thanks.

-- 
~Randy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-29 01:20 +0200
  Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Jonathan Corbet <corbet@lwn.net> - 2017-08-30 23:30 +0200
    Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 00:10 +0200
      Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-08-31 00:20 +0200
        Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Jonathan Corbet <corbet@lwn.net> - 2017-08-31 00:40 +0200
          Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 01:10 +0200
            Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 01:10 +0200
              Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 01:20 +0200
      Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-08-31 12:00 +0200
        Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Jani Nikula <jani.nikula@linux.intel.com> - 2017-08-31 15:30 +0200
          Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-08-31 16:00 +0200
            Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Jonathan Corbet <corbet@lwn.net> - 2017-08-31 16:20 +0200
              Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 17:50 +0200
                Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Jani Nikula <jani.nikula@linux.intel.com> - 2017-08-31 18:10 +0200
                Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 18:30 +0200
                Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Jani Nikula <jani.nikula@linux.intel.com> - 2017-08-31 18:40 +0200
                Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 19:40 +0200
                Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 20:00 +0200
                Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Jani Nikula <jani.nikula@linux.intel.com> - 2017-08-31 20:00 +0200
                Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 20:10 +0200
        Re: [PATCH 1/2] docs: kernel-doc comments are ASCII Randy Dunlap <rdunlap@infradead.org> - 2017-08-31 18:00 +0200

csiph-web