Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac

From	"Kani, Toshimitsu" <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac
Date	2017-08-31 18:20 +0200
Message-ID	<ukAmd-7Ri-5@gated-at.bofh.it> (permalink)
References	<uhMWC-6Rd-9@gated-at.bofh.it> <uhMWC-6Rd-13@gated-at.bofh.it> <ukvmy-4Aq-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-08-31 at 12:56 +0200, Borislav Petkov wrote:
> On Wed, Aug 23, 2017 at 04:54:45PM -0600, Toshi Kani wrote:
 :
> > ---
> >  drivers/edac/ghes_edac.c |   29 ++++++++++++++++++++++++-----
> >  1 file changed, 24 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
> > index 8d904df..0030a09 100644
> > --- a/drivers/edac/ghes_edac.c
> > +++ b/drivers/edac/ghes_edac.c
> > @@ -38,6 +38,10 @@ static struct ghes_edac_pvt *ghes_pvt;
> >   */
> >  static DEFINE_SPINLOCK(ghes_lock);
> >  
> > +/* Set 1 to skip the platform check */
> > +static bool __read_mostly ghes_edac_force_load;
> 
> It is static - "force_load" as a bool name is enough.

Will do.

> > +module_param_named(force_load, ghes_edac_force_load, bool, 0);
> 
> ERROR: Use 4 digit octal (0777) not decimal permissions
> #53: FILE: drivers/edac/ghes_edac.c:43:
> +module_param_named(force_load, ghes_edac_force_load, bool, 0);
> 
> This last param is @perm: visibility in sysfs. Why not visible in
> sysfs?

I followed in the footsteps of 'ghes_disable', which is also a kernel
boot option and uses 0.

> > +
> >  /* Memory Device - Type 17 of SMBIOS spec */
> >  struct memdev_dmi_entry {
> >  	u8 type;
> > @@ -415,6 +419,15 @@ void ghes_edac_report_mem_error(struct ghes
> > *ghes, int sev,
> >  	spin_unlock_irqrestore(&ghes_lock, flags);
> >  }
> >  
> > +/*
> > + * Known systems that are safe to enable this module.
> > + * "ghes_edac.force_load=1" skips this check if necessary.
> 
> Put this second sentence over the parameter definition.

Will do.

Thanks,
-Toshi

Thread

Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-31 13:00 +0200
  Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2017-08-31 18:20 +0200
    Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac Borislav Petkov <bp@alien8.de> - 2017-08-31 19:00 +0200

csiph-web