Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1724419

Re: [PATCH] driver core: bus: Fix a potential double free

Show all headers | View raw

On Tue, Aug 29, 2017 at 09:23:49PM +0200, Christophe JAILLET wrote:
> The .release function of driver_ktype is 'driver_release()'.
> This function frees the container_of this kobject.
> 
> So, this memory must not be freed explicitly in the error handling path of
> 'bus_add_driver()'. Otherwise a double free will occur.

Oh, nice catch!

> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> I have left the 'drv->p = NULL' even if it looks useless to me. It does not
> hurt. I have also left a comment to explain why we do not free 'drv->p'
> explicitly before zeroing this pointer.

We need that for when people do static structures.  Like as is done for
drivers.  Well, I think that's why we need it, can't really remember,
might as well be safe, the error handling paths here are crazy at
times...

thnaks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] driver core: bus: Fix a potential double free Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-29 21:30 +0200
  Re: [PATCH] driver core: bus: Fix a potential double free Greg KH <gregkh@linuxfoundation.org> - 2017-08-31 19:00 +0200

csiph-web