Re: [PATCH V6] perf: Add PERF_SAMPLE_PHYS_ADDR

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V6] perf: Add PERF_SAMPLE_PHYS_ADDR
Date	2017-08-31 18:50 +0200
Message-ID	<ukAPg-81j-11@gated-at.bofh.it> (permalink)
References	<uhEPn-1DV-17@gated-at.bofh.it> <uhEZ3-1Jk-7@gated-at.bofh.it> <uhF8K-1Mw-21@gated-at.bofh.it> <uhHke-3jd-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Wed, Aug 23, 2017 at 10:00:37AM -0700, Stephane Eranian escreveu:
> On Wed, Aug 23, 2017 at 7:39 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Wed, Aug 23, 2017 at 04:33:08PM +0200, Peter Zijlstra wrote:
> >> > @@ -6145,6 +6183,9 @@ void perf_prepare_sample(struct perf_event_header *header,
> >> >
> >> >             header->size += size;
> >> >     }
> >> > +
> >> > +   if (sample_type & PERF_SAMPLE_PHYS_ADDR)
> >> > +           data->phys_addr = perf_virt_to_phys(data->addr);
> >>
> >> Only problem with this now is that it requires SAMPLE_ADDR to also be
> >> set in order to obtain data->addr.
> >>
> >> Either fix all to set data->attr for (SAMPLE_ADDR || SAMPLE_PHYS_ADDR)
> >> or mandate SAMPLE_ADDR when SAMPLE_PHYS_ADDR.
> >
> > I think the former suggestion is better, as it allows for smaller
> > samples.
> 
> Agreed. I may only care about physical addresses, so SAMPLE_PHYS_ADDR
> should suffice from the user.
> The kernel must save the virtual address in data->addr, and then convert it.

Stephane, have you took the time to test this together with Kan's latest
patchkit for tools/perf? v2? If so can I have your Tested-by or just an
Acked-by?

Thanks,

- Arnaldo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V6] perf: Add PERF_SAMPLE_PHYS_ADDR Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-31 18:50 +0200

csiph-web