Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf

From	Fabrice Gasnier <fabrice.gasnier@st.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf
Date	2017-08-30 11:20 +0200
Message-ID	<uk7kd-6sc-5@gated-at.bofh.it> (permalink)
References	<ujrO3-5H0-33@gated-at.bofh.it> <ujrXI-5Zo-23@gated-at.bofh.it> <ujUn0-6IJ-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/29/2017 08:57 PM, Mark Brown wrote:
> On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote:
> 
>> +	ret = clk_prepare_enable(priv->clk);
>> +	if (ret) {
>> +		dev_err(&pdev->dev, "clk prepare failed\n");
> 
> If you're printing an error include the error code, it'll help users
> figure out what went wrong.
Hi Mark,

Thanks for reviewing,
I'll add it in v2.
> 
>> +	dev_info(&pdev->dev, "STM32 VREFBUF initialized\n");
> 
> This is just noise, remove it.

I'll remove it in v2.
> 
>> +static int __init stm32_vrefbuf_init(void)
>> +{
>> +	return platform_driver_register(&stm32_vrefbuf_driver);
>> +}
>> +subsys_initcall(stm32_vrefbuf_init);
> 
> Why is this at subsys_initcall()?
> 
Several consumers depend on it when it's being used, among which: STM32
internal ADC and DAC, but also external components. Purpose is to ensure
it's ready before these drivers gets probed, instead of being deferred.
Is it ok to keep it ?

Please let me know,
Best Regards,
Fabrice

Thread

[RESEND PATCH 0/3] Add support for STM32 vrefbuf regulator Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-08-28 15:10 +0200
  [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-08-28 15:10 +0200
    Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf Mark Brown <broonie@kernel.org> - 2017-08-29 21:30 +0200
      Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-08-30 11:20 +0200
        Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf Mark Brown <broonie@kernel.org> - 2017-08-30 17:10 +0200
          Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-08-30 17:30 +0200
  [RESEND PATCH 3/3] ARM: dts: stm32: add vrefbuf to stm32h743 Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-08-28 15:10 +0200

csiph-web