Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

From	Antoine Tenart <antoine.tenart@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver
Date	2017-08-30 08:40 +0200
Message-ID	<uk4Pn-4RL-7@gated-at.bofh.it> (permalink)
References	<ujtGa-6PN-15@gated-at.bofh.it> <ujtGb-6PN-33@gated-at.bofh.it> <uk3zY-484-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Kishon,

On Wed, Aug 30, 2017 at 10:49:13AM +0530, Kishon Vijay Abraham I wrote:
> On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote:
> > +
> > +static int mvebu_comphy_set_mode_sgmii(struct phy *phy, enum phy_mode mode)
> 
> the mode need not be passed as argument here since this function is only for
> sgmii mode.

Sure, I'll remove it.

> > +{
> > +	struct mvebu_comphy_lane *lane = phy_get_drvdata(phy);
> > +	struct mvebu_comphy_priv *priv = lane->priv;
> > +	u32 val;
> > +
> > +	mvebu_comphy_ethernet_init_reset(lane, mode);
> > +
> > +	val = readl(priv->base + MVEBU_COMPHY_RX_CTRL1(lane->id));
> > +	val &= ~MVEBU_COMPHY_RX_CTRL1_CLK8T_EN;
> > +	val |= MVEBU_COMPHY_RX_CTRL1_RXCLK2X_SEL;
> > +	writel(val, priv->base + MVEBU_COMPHY_RX_CTRL1(lane->id));
> > +
> > +	val = readl(priv->base + MVEBU_COMPHY_DLT_CTRL(lane->id));
> > +	val &= ~MVEBU_COMPHY_DLT_CTRL_DTL_FLOOP_EN;
> > +	writel(val, priv->base + MVEBU_COMPHY_DLT_CTRL(lane->id));
> > +
> > +	regmap_read(priv->regmap, MVEBU_COMPHY_CONF1(lane->id), &val);
> > +	val &= ~MVEBU_COMPHY_CONF1_USB_PCIE;
> > +	val |= MVEBU_COMPHY_CONF1_PWRUP;
> > +	regmap_write(priv->regmap, MVEBU_COMPHY_CONF1(lane->id), val);
> > +
> > +	val = readl(priv->base + MVEBU_COMPHY_GEN1_S0(lane->id));
> > +	val &= ~MVEBU_COMPHY_GEN1_S0_TX_EMPH(0xf);
> > +	val |= MVEBU_COMPHY_GEN1_S0_TX_EMPH(0x1);
> > +	writel(val, priv->base + MVEBU_COMPHY_GEN1_S0(lane->id));
> > +
> > +	return mvebu_comphy_init_plls(lane, mode);
> > +}
> > +
> > +static int mvebu_comphy_set_mode_10gkr(struct phy *phy, enum phy_mode mode)
> 
> same here..

And here as well.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-28 17:00 +0200
  Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-29 13:10 +0200
    Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-29 13:30 +0200
      Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-29 14:30 +0200
        Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-29 15:20 +0200
          Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-30 07:40 +0200
            Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-30 08:50 +0200
  Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-30 07:20 +0200
    Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-30 08:40 +0200

csiph-web