Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1721852

Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE

From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE
Date 2017-08-28 19:50 +0200
Message-ID <ujwkG-8vp-5@gated-at.bofh.it> (permalink)
References <u6WPE-4Ir-9@gated-at.bofh.it> <ujfDb-6lS-1@gated-at.bofh.it> <ujw1l-8pb-31@gated-at.bofh.it> <ujwaZ-8sm-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Aug 28, 2017 at 10:38 AM, Nick Desaulniers
<ndesaulniers@google.com> wrote:
> I think Kees' proposal is a better solution; rather than require all
> usage of device table to remember to add const, have the macro add it
> for all users.  Otherwise if you require caller's to add it, they may
> forget.

And with the coccinelle script, it should be easy to invert the logic
and remove const from the callers...

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE Stefan Agner <stefan@agner.ch> - 2017-08-28 02:00 +0200
  Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE Kees Cook <keescook@chromium.org> - 2017-08-28 19:30 +0200
    Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE Nick Desaulniers <ndesaulniers@google.com> - 2017-08-28 19:40 +0200
      Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE Kees Cook <keescook@chromium.org> - 2017-08-28 19:50 +0200
        Re: module: Remove const attribute from alias for MODULE_DEVICE_TABLE Stefan Agner <stefan@agner.ch> - 2017-08-29 04:30 +0200

csiph-web