Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined
Date	2017-08-28 19:00 +0200
Message-ID	<ujvyi-80q-5@gated-at.bofh.it> (permalink)
References	<ui1Ci-7QZ-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 24, 2017 at 04:44:27PM +0200, Alexandre Belloni wrote:
> mach_beep is defined arch/m68k/kernel/setup_mm.c which is compiled only
> when MMU is selected.
> 
> To avoid linking errors, make INPUT_M68K_BEEP depend on MMU.

Hmm, can we maybe pull mach_beep from setup_mm.c to setup.c? MMU
dependency seems to be artificial.

> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/input/misc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 3872488c3fd7..7a44f633a413 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -178,7 +178,7 @@ config INPUT_SPARCSPKR
>  
>  config INPUT_M68K_BEEP
>  	tristate "M68k Beeper support"
> -	depends on M68K
> +	depends on M68K && MMU
>  
>  config INPUT_MAX77693_HAPTIC
>  	tristate "MAXIM MAX77693/MAX77843 haptic controller support"
> -- 
> 2.14.1
> 

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is  undefined Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-08-28 19:00 +0200
  Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-28 19:20 +0200
    Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is  undefined Greg Ungerer <gerg@linux-m68k.org> - 2017-08-29 02:30 +0200

csiph-web