Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721821

RE: linux-next: manual merge of the scsi tree with the staging tree

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Adding SParMaintainer@unisys.com.

-Sameer Wadgaonkar

-----Original Message-----
From: greg@kroah.com [mailto:greg@kroah.com] 
Sent: Monday, August 28, 2017 12:44 PM
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: sfr@canb.auug.org.au; linux-kernel@vger.kernel.org;
jejb@linux.vnet.ibm.com; hare@suse.de; linux-next@vger.kernel.org;
martin.petersen@oracle.com; Wadgaonkar, Sameer Laxmikant
<Sameer.Wadgaonkar@unisys.com>
Subject: Re: linux-next: manual merge of the scsi tree with the staging tree

On Mon, Aug 28, 2017 at 04:36:06PM +0000, Bart Van Assche wrote:
> On Mon, 2017-08-28 at 18:05 +0200, greg@kroah.com wrote:
> > On Mon, Aug 28, 2017 at 03:41:28PM +0000, Bart Van Assche wrote:
> > > * Most SCSI drivers exist under drivers/scsi, including the
virtio-scsi and
> > >   xen-scsifront drivers. So why has the visorhba driver been added
under
> > >   unisys/visorhba?
> > 
> > That's because right now it's still a staging driver.  Also, there are
> > other scsi drivers in other portions of the kernel tree (like the USB
> > driver), so there's no hard rule that all scsi drivers have to be under
> > drivers/scsi/
> > 
> > <snip>
> > 
> > Please provide this review to them, on the properly mailing list, I'm
> > sure they would be glad to get it.
> 
> OK, I will do that. BTW, is there a written down version of the rules for
> adding a driver under drivers/staging available somewhere? 

The only 2 rules for adding a new drivers/staging driver is:
	- has to compile
	- correct license
and sometimes we let code in if the first one isn't true :)

> As far as I can
> see the visorhba driver went in without the linux-scsi mailing list having
> been CC-ed. See also Benjamin Romer, [PATCH] staging: unisys: Add s-Par
> visorhba, linux-driver-devel mailing list, July 2015
> (https://marc.info/?l=linux-driver-devel&m=143681271902628).

That's totally normal, why would the scsi developers care about a
staging driver in such a rough state.  Only when it looks "good enough"
would we ask for a scsi developer review to move it out of staging.

hope this helps,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: manual merge of the scsi tree with the staging tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-28 08:50 +0200
  Re: linux-next: manual merge of the scsi tree with the staging tree Greg KH <greg@kroah.com> - 2017-08-28 08:50 +0200
    Re: linux-next: manual merge of the scsi tree with the staging tree Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-28 17:50 +0200
      Re: linux-next: manual merge of the scsi tree with the staging tree "greg@kroah.com" <greg@kroah.com> - 2017-08-28 18:10 +0200
        Re: linux-next: manual merge of the scsi tree with the staging tree Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-28 18:40 +0200
          Re: linux-next: manual merge of the scsi tree with the staging tree "greg@kroah.com" <greg@kroah.com> - 2017-08-28 18:50 +0200
            RE: linux-next: manual merge of the scsi tree with the staging tree "Wadgaonkar, Sameer Laxmikant" <Sameer.Wadgaonkar@unisys.com> - 2017-08-28 19:10 +0200
            Re: linux-next: manual merge of the scsi tree with the staging tree James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-08-28 20:00 +0200
              Re: linux-next: manual merge of the scsi tree with the staging tree "greg@kroah.com" <greg@kroah.com> - 2017-08-28 20:50 +0200
  Re: linux-next: manual merge of the scsi tree with the staging tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-09-05 02:20 +0200

csiph-web