Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1721756

Re: [PATCH v2] eeprom: idt_89hpesx: Support both ACPI and OF probing

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] eeprom: idt_89hpesx: Support both ACPI and OF probing
Date 2017-08-28 17:40 +0200
Message-ID <ujuiR-7jd-7@gated-at.bofh.it> (permalink)
References <ucbl0-7TS-27@gated-at.bofh.it> <ucpxE-16N-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Aug 09, 2017 at 10:08:46AM +0700, quochuybk2010@gmail.com wrote:
> From: Huy Duong <qhuyduong@hotmail.com>
> 
> Allow the idt_89hpesx driver to get information from child nodes from
> both OF and ACPI by using more generic fwnode_property_read*() functions.
> 
> Below is an example of instantiating idt_89hpesx driver via ACPI Table:
> 
> Device(IDT0) {
>  Name(_HID, "PRP0001")
>  Name(_CID, "PRP0001")
>  Name(_CCA, ONE)
>  Name(_STR, Unicode("IDT SW I2C Slave"))
>  Name(_CRS, ResourceTemplate () {
>   I2cSerialBus (0x74, ControllerInitiated, 1000,
>    AddressingMode7Bit, "\\_SB.I2CS",
>    0x00, ResourceConsumer, ,
>   )
>  })
>  Name (_DSD, Package () {
>   ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>   Package () {
>    Package () {"compatible", "idt,89hpes32nt8ag2"},
>   },
>  })
>  Device (EPR0) {
>   Name (_DSD, Package () {
>    ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>    Package () {
>     Package () {"compatible", "onsemi,24c64"},
>     Package () {"reg", 0x50},
>    }
>   })
>  }
> }
> 
> Signed-off-by: Huy Duong <qhuyduong@hotmail.com>
> Acked-by: Serge Semin <fancer.lancer@gmail.com>
> ---
> Changes in v2:
> * Replace <linux/of.h> with <linux/property.h>
> * Change eeprom_addr to u32 to avoid type casting

Doesn't apply to my tree at all.  Can you rebase it against
char-misc.git on the char-misc-next branch and resend?

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v2] eeprom: idt_89hpesx: Support both ACPI and OF probing Greg KH <gregkh@linuxfoundation.org> - 2017-08-28 17:40 +0200

csiph-web