Re: [PATCH 3/3] iommu: s390: constify iommu_ops

From	Gerald Schaefer <gerald.schaefer@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] iommu: s390: constify iommu_ops
Date	2017-08-28 18:00 +0200
Message-ID	<ujuCd-7qi-9@gated-at.bofh.it> (permalink)
References	<ujrbj-5ug-7@gated-at.bofh.it>
Organization	IBM Deutschland Research & Development GmbH / Vorsitzende des Aufsichtsrats: Martina Koederitz / Geschaeftsfuehrung: Dirk Wittkopp / Sitz der Gesellschaft: Boeblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294

Show all headers | View raw

On Mon, 28 Aug 2017 17:42:50 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> iommu_ops are not supposed to change at runtime.
> Functions 'bus_set_iommu' working with const iommu_ops provided
> by <linux/iommu.h>. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/iommu/s390-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>

> 
> diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
> index 8788640..400d75f 100644
> --- a/drivers/iommu/s390-iommu.c
> +++ b/drivers/iommu/s390-iommu.c
> @@ -327,7 +327,7 @@ static size_t s390_iommu_unmap(struct iommu_domain *domain,
>  	return size;
>  }
> 
> -static struct iommu_ops s390_iommu_ops = {
> +static const struct iommu_ops s390_iommu_ops = {
>  	.capable = s390_iommu_capable,
>  	.domain_alloc = s390_domain_alloc,
>  	.domain_free = s390_domain_free,

Thread

[PATCH 3/3] iommu: s390: constify iommu_ops Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-28 14:20 +0200
  Re: [PATCH 3/3] iommu: s390: constify iommu_ops Gerald Schaefer <gerald.schaefer@de.ibm.com> - 2017-08-28 18:00 +0200
  Re: [PATCH 3/3] iommu: s390: constify iommu_ops Joerg Roedel <joro@8bytes.org> - 2017-08-30 15:30 +0200

csiph-web