Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static
Date	2017-08-28 17:10 +0200
Message-ID	<ujtPQ-78t-9@gated-at.bofh.it> (permalink)
References	<uhAsp-7hk-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 23, 2017 at 10:47:52AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The boolean no_msi is local to the source and does not need to be in
> global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'no_msi' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/misc/pci_endpoint_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 1f64d943794d..deb203026496 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -73,7 +73,7 @@ static DEFINE_IDA(pci_endpoint_test_ida);
>  #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \
>  					    miscdev)
>  
> -bool no_msi;
> +static bool no_msi;
>  module_param(no_msi, bool, 0444);
>  MODULE_PARM_DESC(no_msi, "Disable MSI interrupt in pci_endpoint_test");

This doesn't apply to my tree at all :(

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-28 17:10 +0200

csiph-web