Re: [PATCH] nokia n900: update dts with camera support

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] nokia n900: update dts with camera support
Date	2017-08-28 16:10 +0200
Message-ID	<ujsTM-6zH-31@gated-at.bofh.it> (permalink)
References	(2 earlier) <ueSca-76K-27@gated-at.bofh.it> <ufdzY-3q9-23@gated-at.bofh.it> <ufdzY-3q9-33@gated-at.bofh.it> <ufe31-3PN-39@gated-at.bofh.it> <ufgxP-5ua-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi!

> > > Well, strobe property above already uses = <0>/<1> format, as do
> > > others.
> >
> > > Problem with "false = property does not exist" is that you don't know
> > > if it is "someone forgot to define it" or "someone made a typo" or
> > > "dts is too old to know about this property" or "the property indeed
> > > should be false"...
> >
> > As this is an established practice, I think we should follow it for bool
> > properties.
> 
> Yes it's common practice, there is also device_property_read_bool()
> to get the value.
> 
> > We could change the existing ones, too, and leave some extra checks in
> > place to handle old dtbs.
> 
> The following should be downward compatible:
> 
> var = read_bool();
> if (var && !read_int())
>     var = false;
> 
> Btw. DT people should be CC'd for DT binding additions/changes.

Ok, so for now we do crc=1 by default. Now we'd like to have crc
support configurable in the dts. But if we just introduce "crc;"
option, it will break old dts users. We could introduce "no-crc;" and
that would work in this particular case, but will break when we want
different defaults at different devices.

Anyway, introducing "no-crc;" seems pretty ugly to me. I'd rather do
"crc=<0>;", in a similar way we handle other options now.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] nokia n900: update dts with camera support Pavel Machek <pavel@ucw.cz> - 2017-08-28 16:10 +0200
  Re: [PATCH] nokia n900: update dts with camera support Sakari Ailus <sakari.ailus@iki.fi> - 2017-08-28 17:10 +0200
    Re: [PATCH] nokia n900: update dts with camera support Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2017-08-28 20:30 +0200

csiph-web