Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1721556
| From | Dennis Yang <dennisyang@qnap.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] md/raid5: preserve STRIPE_ON_UNPLUG_LIST in break_stripe_batch_list |
| Date | 2017-08-28 14:10 +0200 |
| Message-ID | <ujr1D-5rf-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
break_stripe_batch_list() did not preserve STRIPE_ON_UNPLUG_LIST which is set when a stripe_head gets queued to the stripe_head list maintained by raid5_plug_cb and waiting for releasing after blk_unplug(). In release_stripe_plug(), if a stripe_head has its STRIPE_ON_UNPLUG_LIST set, it indicates that this stripe_head is already in the raid5_plug_cb list and release_stripe() would be called instead to drop a reference count. Otherwise, the STRIPE_ON_UNPLUG_LIST bit would be set for this stripe_head and it will get queued into the raid5_plug_cb list. Without preserving STRIPE_ON_UNPLUG_LIST in break_stripe_batch_list(), a stripe_head could be re-added to the raid5_plug_cb list while it is currently on that list and waiting to be released. This would mess up the raid5_plug_cb and leads to soft/hard lockup in raid5_unplug() or kernel crash. Signed-off-by: Dennis Yang <dennisyang@qnap.com> --- drivers/md/raid5.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index e92dd2d..faf3cfd 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -4611,7 +4611,8 @@ static void break_stripe_batch_list(struct stripe_head *head_sh, set_mask_bits(&sh->state, ~(STRIPE_EXPAND_SYNC_FLAGS | (1 << STRIPE_PREREAD_ACTIVE) | - (1 << STRIPE_DEGRADED)), + (1 << STRIPE_DEGRADED) | + (1 << STRIPE_ON_UNPLUG_LIST)), head_sh->state & (1 << STRIPE_INSYNC)); sh->check_state = head_sh->check_state; -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] md/raid5: preserve STRIPE_ON_UNPLUG_LIST in break_stripe_batch_list Dennis Yang <dennisyang@qnap.com> - 2017-08-28 14:10 +0200
Re: [PATCH] md/raid5: preserve STRIPE_ON_UNPLUG_LIST in break_stripe_batch_list Shaohua Li <shli@kernel.org> - 2017-09-01 07:40 +0200
Re: [PATCH] md/raid5: preserve STRIPE_ON_UNPLUG_LIST in break_stripe_batch_list Dennis Yang <dennisyang@qnap.com> - 2017-09-01 11:30 +0200
Re: [PATCH] md/raid5: preserve STRIPE_ON_UNPLUG_LIST in break_stripe_batch_list Shaohua Li <shli@kernel.org> - 2017-09-05 22:40 +0200
Re: [PATCH] md/raid5: preserve STRIPE_ON_UNPLUG_LIST in break_stripe_batch_list Dennis Yang <dennisyang@qnap.com> - 2017-09-06 05:20 +0200
csiph-web