Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721522

Re: [PATCH] perf/ftrace: fix doubled traces of perf on ftrace:function

Show all headers | View raw

On Fri, Aug 25, 2017 at 09:49:37PM +0800, Zhou Chengming wrote:

SNIP

> diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c
> index 562fa69..70c5025 100644
> --- a/kernel/trace/trace_event_perf.c
> +++ b/kernel/trace/trace_event_perf.c
> @@ -306,6 +306,7 @@ void perf_trace_buf_update(void *record, u16 type)
>  perf_ftrace_function_call(unsigned long ip, unsigned long parent_ip,
>  			  struct ftrace_ops *ops, struct pt_regs *pt_regs)
>  {
> +	struct perf_event *event;
>  	struct ftrace_entry *entry;
>  	struct hlist_head *head;
>  	struct pt_regs regs;
> @@ -329,8 +330,9 @@ void perf_trace_buf_update(void *record, u16 type)
>  
>  	entry->ip = ip;
>  	entry->parent_ip = parent_ip;
> +	event = container_of(ops, struct perf_event, ftrace_ops); 

nit, white space at the end of the line ^^^

but the change looks good to me

Reviewed-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf/ftrace: fix doubled traces of perf on ftrace:function Zhou Chengming <zhouchengming1@huawei.com> - 2017-08-25 15:50 +0200
  Re: [PATCH] perf/ftrace: fix doubled traces of perf on  ftrace:function Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 16:00 +0200
  Re: [PATCH] perf/ftrace: fix doubled traces of perf on  ftrace:function Jiri Olsa <jolsa@redhat.com> - 2017-08-28 13:10 +0200
  [tip:perf/urgent] perf/ftrace: Fix double traces of perf on  ftrace:function tip-bot for Zhou Chengming <tipbot@zytor.com> - 2017-08-29 15:20 +0200

csiph-web