Re: [PATCH] iommu: qcom: annotate PM functions as __maybe_unused

From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iommu: qcom: annotate PM functions as __maybe_unused
Date	2017-08-28 11:30 +0200
Message-ID	<ujowN-3Qe-7@gated-at.bofh.it> (permalink)
References	<uhEcG-1bd-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 23, 2017 at 03:42:45PM +0200, Arnd Bergmann wrote:
> The qcom_iommu_disable_clocks() function is only called from PM
> code that is hidden in an #ifdef, causing a harmless warning without
> CONFIG_PM:
> 
> drivers/iommu/qcom_iommu.c:601:13: error: 'qcom_iommu_disable_clocks' defined but not used [-Werror=unused-function]
>  static void qcom_iommu_disable_clocks(struct qcom_iommu_dev *qcom_iommu)
> drivers/iommu/qcom_iommu.c:581:12: error: 'qcom_iommu_enable_clocks' defined but not used [-Werror=unused-function]
>  static int qcom_iommu_enable_clocks(struct qcom_iommu_dev *qcom_iommu)
> 
> Replacing that #ifdef with __maybe_unused annotations lets the compiler
> drop the functions silently instead.
> 
> Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/iommu/qcom_iommu.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Applied, thanks.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] iommu: qcom: annotate PM functions as __maybe_unused Joerg Roedel <joro@8bytes.org> - 2017-08-28 11:30 +0200

csiph-web