Re: [PATCH] mm/page_alloc: don't reserve ZONE_HIGHMEM for ZONE_MOVABLE request

From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/page_alloc: don't reserve ZONE_HIGHMEM for ZONE_MOVABLE request
Date	2017-08-28 08:50 +0200
Message-ID	<ujm1Y-2ab-3@gated-at.bofh.it> (permalink)
References	<uhTbI-2lw-17@gated-at.bofh.it> <uhWVY-4Hm-29@gated-at.bofh.it> <uiaFA-5hT-9@gated-at.bofh.it> <uihH4-1eB-9@gated-at.bofh.it> <ujg6e-6Od-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

+CC linux-api

On 08/28/2017 02:28 AM, Joonsoo Kim wrote:
> On Fri, Aug 25, 2017 at 09:56:10AM +0200, Vlastimil Babka wrote:
>> On 08/25/2017 02:20 AM, Joonsoo Kim wrote:
>>> On Thu, Aug 24, 2017 at 11:41:58AM +0200, Vlastimil Babka wrote:
>>>
>>> Hmm, this is already pointed by Minchan and I have answered that.
>>>
>>> lkml.kernel.org/r/<20170421013243.GA13966@js1304-desktop>
>>>
>>> If you have a better idea, please let me know.
>>
>> My idea is that size of sysctl_lowmem_reserve_ratio is ZONE_NORMAL+1 and
>> it has no entries for zones > NORMAL. The
>> setup_per_zone_lowmem_reserve() is adjusted to only set
>> lower_zone->lowmem_reserve[j] for idx <= ZONE_NORMAL.
>>
>> I can't imagine somebody would want override the ratio for HIGHMEM or
>> MOVABLE
>> (where it has no effect anyway) so the simplest thing is not to expose
>> it at all.
> 
> Seems reasonable. However, if there is a user who checks
> sysctl_lowmem_reserve_ratio entry for HIGHMEM and change it, suggested
> interface will cause a problem since it doesn't expose ratio for
> HIGHMEM. Am I missing something?

As you explained, it makes little sense to change it for HIGHMEM which
only affects MOVABLE allocations. Also I doubt there are many systems
with both HIGHMEM (implies 32bit) *and* MOVABLE (implies NUMA, memory
hotplug...) zones. So I would just remove it, and if somebody will
really miss it, we can always add it back. In any case, please CC
linux-api on the next version.

> Thanks.
> 
> 
>>
>>> Thanks.
>>>
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org.  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Thread

Re: [PATCH] mm/page_alloc: don't reserve ZONE_HIGHMEM for  ZONE_MOVABLE request Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2017-08-28 02:30 +0200
  Re: [PATCH] mm/page_alloc: don't reserve ZONE_HIGHMEM for  ZONE_MOVABLE request Vlastimil Babka <vbabka@suse.cz> - 2017-08-28 08:50 +0200
    Re: [PATCH] mm/page_alloc: don't reserve ZONE_HIGHMEM for  ZONE_MOVABLE request Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2017-08-29 02:40 +0200
      Re: [PATCH] mm/page_alloc: don't reserve ZONE_HIGHMEM for  ZONE_MOVABLE request Vlastimil Babka <vbabka@suse.cz> - 2017-08-29 09:10 +0200

csiph-web