Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721058

Re: [PATCH v2 4/5] cramfs: add mmap support

Show all headers | View raw

On Wed, Aug 16, 2017 at 01:35:35PM -0400, Nicolas Pitre wrote:

> +static const struct vm_operations_struct cramfs_vmasplit_ops;
> +static int cramfs_vmasplit_fault(struct vm_fault *vmf)
> +{
> +	struct mm_struct *mm = vmf->vma->vm_mm;
> +	struct vm_area_struct *vma, *new_vma;
> +	unsigned long split_val, split_addr;
> +	unsigned int split_pgoff, split_page;
> +	int ret;
> +
> +	/* Retrieve the vma split address and validate it */
> +	vma = vmf->vma;
> +	split_val = (unsigned long)vma->vm_private_data;
> +	split_pgoff = split_val & 0xffff;
> +	split_page = split_val >> 16;
> +	split_addr = vma->vm_start + split_page * PAGE_SIZE;
> +	pr_debug("fault: addr=%#lx vma=%#lx-%#lx split=%#lx\n",
> +		 vmf->address, vma->vm_start, vma->vm_end, split_addr);
> +	if (!split_val || split_addr >= vma->vm_end || vmf->address < split_addr)
> +		return VM_FAULT_SIGSEGV;
> +
> +	/* We have some vma surgery to do and need the write lock. */
> +	up_read(&mm->mmap_sem);
> +	if (down_write_killable(&mm->mmap_sem))
> +		return VM_FAULT_RETRY;
> +
> +	/* Make sure the vma didn't change between the locks */
> +	vma = find_vma(mm, vmf->address);
> +	if (vma->vm_ops != &cramfs_vmasplit_ops) {
> +		/*
> +		 * Someone else raced with us and could have handled the fault.
> +		 * Let it go back to user space and fault again if necessary.
> +		 */
> +		downgrade_write(&mm->mmap_sem);
> +		return VM_FAULT_NOPAGE;
> +	}
> +
> +	/* Split the vma between the directly mapped area and the rest */
> +	ret = split_vma(mm, vma, split_addr, 0);

Egads...  Everything else aside, who said that your split_... will have
anything to do with the vma you get from find_vma()?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/5] cramfs: add mmap support Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-28 08:50 +0200
  Re: [PATCH v2 4/5] cramfs: add mmap support Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-08-28 15:40 +0200
    Re: [PATCH v2 4/5] cramfs: add mmap support Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-28 16:30 +0200
      Re: [PATCH v2 4/5] cramfs: add mmap support Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-08-28 21:20 +0200
        RE: [PATCH v2 4/5] cramfs: add mmap support Chris Brandt <Chris.Brandt@renesas.com> - 2017-08-29 21:40 +0200
          RE: [PATCH v2 4/5] cramfs: add mmap support Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-08-29 22:10 +0200
            RE: [PATCH v2 4/5] cramfs: add mmap support Chris Brandt <Chris.Brandt@renesas.com> - 2017-08-29 22:20 +0200
            RE: [PATCH v2 4/5] cramfs: add mmap support Chris Brandt <Chris.Brandt@renesas.com> - 2017-08-31 04:40 +0200

csiph-web