Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720942

Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

Show all headers | View raw

On 8/27/17 3:26 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 27 Aug 2017 21:18:37 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.

Did coccinelle trip on the message or the fact you weren't returning NULL?

> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>   drivers/connector/cn_queue.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/connector/cn_queue.c b/drivers/connector/cn_queue.c
> index 1f8bf054d11c..e4f31d679f02 100644
> --- a/drivers/connector/cn_queue.c
> +++ b/drivers/connector/cn_queue.c
> @@ -40,10 +40,8 @@ cn_queue_alloc_callback_entry(struct cn_queue_dev *dev, const char *name,
>   	struct cn_callback_entry *cbq;
>   
>   	cbq = kzalloc(sizeof(*cbq), GFP_KERNEL);
> -	if (!cbq) {
> -		pr_err("Failed to create new callback queue.\n");
> +	if (!cbq)
>   		return NULL;
> -	}

Wny not:

	if (!cbq) {
		pr_err("Failed to create new callback queue.\n");
+		return NULL;
	}

>   
>   	atomic_set(&cbq->refcnt, 1);
>   
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] connector: Delete an error message for a failed memory  allocation in cn_queue_alloc_callback_entry() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-27 21:30 +0200
  Re: [PATCH] connector: Delete an error message for a failed memory  allocation in cn_queue_alloc_callback_entry() "Waskiewicz Jr, Peter" <peter.waskiewicz.jr@intel.com> - 2017-08-28 01:20 +0200
    Re: [PATCH] connector: Delete an error message for a failed memory  allocation in cn_queue_alloc_callback_entry() Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-28 08:10 +0200
      Re: [PATCH] connector: Delete an error message for a failed memory  allocation in cn_queue_alloc_callback_entry() "Waskiewicz Jr, Peter" <peter.waskiewicz.jr@intel.com> - 2017-08-28 16:10 +0200
    Re: connector: Delete an error message for a failed memory allocation  in cn_queue_alloc_callback_entry() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-28 09:10 +0200
  Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry() Evgeniy Polyakov <zbr@ioremap.net> - 2017-09-05 15:20 +0200

csiph-web