Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720922

[PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 27 Aug 2017 22:00:22 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/leds/leds-powernv.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c
index b2a98c7b521b..b1adbd70ce2e 100644
--- a/drivers/leds/leds-powernv.c
+++ b/drivers/leds/leds-powernv.c
@@ -224,12 +224,8 @@ static int powernv_led_create(struct device *dev,
 	powernv_led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s",
 						powernv_led->loc_code,
 						led_type_desc);
-	if (!powernv_led->cdev.name) {
-		dev_err(dev,
-			"%s: Memory allocation failed for classdev name\n",
-			__func__);
+	if (!powernv_led->cdev.name)
 		return -ENOMEM;
-	}
 
 	powernv_led->cdev.brightness_set_blocking = powernv_brightness_set;
 	powernv_led->cdev.brightness_get = powernv_brightness_get;
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] leds-PowerNV: Delete an error message for a failed memory  allocation in powernv_led_create() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-27 22:20 +0200
  Re: [PATCH] leds-PowerNV: Delete an error message for a failed  memory allocation in powernv_led_create() Pavel Machek <pavel@ucw.cz> - 2017-08-28 12:20 +0200
  Re: [PATCH] leds-PowerNV: Delete an error message for a failed memory  allocation in powernv_led_create() Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-08-28 22:30 +0200

csiph-web