Groups > linux.kernel > #1720928

Re: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce
Date	2017-08-27 23:10 +0200
Message-ID	<ujcYG-4GL-11@gated-at.bofh.it> (permalink)
References	<uhiFb-3Hr-3@gated-at.bofh.it> <uhj8d-49K-9@gated-at.bofh.it> <uhjhT-4dB-9@gated-at.bofh.it> <uhsXU-2lI-15@gated-at.bofh.it> <uhx1v-5kg-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 23, 2017 at 04:06:24PM +1000, Paul Mackerras wrote:

> It seems to me that it would be better to do the anon_inode_getfd()
> call before the kvm_get_kvm() call, and go to the fail label if it
> fails.

And what happens if another thread does close() on the (guessed) fd?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-27 23:10 +0200
  Re: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Paul Mackerras <paulus@ozlabs.org> - 2017-08-28 06:50 +0200
    Re: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-28 07:30 +0200
      Re: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Paul Mackerras <paulus@ozlabs.org> - 2017-08-28 08:10 +0200
      Re: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Michael Ellerman <mpe@ellerman.id.au> - 2017-08-28 13:40 +0200

csiph-web