Re: [PATCH] DSA support for Micrel KSZ8895

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] DSA support for Micrel KSZ8895
Date	2017-08-29 23:30 +0200
Message-ID	<ujWf8-7TR-13@gated-at.bofh.it> (permalink)
References	(6 earlier) <ujsTM-6zH-15@gated-at.bofh.it> <ujtwt-6Mq-3@gated-at.bofh.it> <ujJrz-8de-13@gated-at.bofh.it> <ujNOy-2zB-21@gated-at.bofh.it> <ujW5r-7PJ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/29/2017 02:15 PM, Pavel Machek wrote:
> On Tue 2017-08-29 14:26:04, Andrew Lunn wrote:
>>> But the MDIO emaulation code is from their driver, after lots of
>>> deletions.
>>
>> Is this driver supposed to run on lots of different OSs? That would
>> explain why they ignored the Linux MDIO and PHY layers.
> 
> It did not look particulary portable.

Part of the problem is that they need to duplicate the standard MII
definitions, whereas we could re-use those from include/linux/mii.h
and/or mdio.h.

> 
>> If possible, please make use of the Linux infrastructure.
> 
> I did not find any infrastructure I could use instead
> ksz_mdio_emulation.

fixed PHY/swphy.c is as close as it could get, but it is a highly
simplified version of this.

> 
> Now, drivers/net/phy/spi_ks8995.c can access the PHY registers, and I
> can not see any translation there, so there may be something I'm
> missing.

I don't see anything in that driver that seems to access PHY registers
what makes you think it does?

There's got to be a way to perform indirect accesses through SPI,
Woojung, do you know?

> 
> Pointers would be welcome at this point.
> 
> Thanks,
> 									Pavel
> 

-- 
Florian

Thread

Re: [PATCH] DSA support for Micrel KSZ8895 Andrew Lunn <andrew@lunn.ch> - 2017-08-27 18:40 +0200
  Re: [PATCH] DSA support for Micrel KSZ8895 Pavel Machek <pavel@ucw.cz> - 2017-08-28 09:10 +0200
    Re: [PATCH] DSA support for Micrel KSZ8895 Andrew Lunn <andrew@lunn.ch> - 2017-08-28 16:10 +0200
      Re: [PATCH] DSA support for Micrel KSZ8895 Maxim Uvarov <muvarov@gmail.com> - 2017-08-28 16:50 +0200
        Re: [PATCH] DSA support for Micrel KSZ8895 Pavel Machek <pavel@ucw.cz> - 2017-08-29 09:50 +0200
          Re: [PATCH] DSA support for Micrel KSZ8895 Andrew Lunn <andrew@lunn.ch> - 2017-08-29 14:30 +0200
            Re: [PATCH] DSA support for Micrel KSZ8895 Pavel Machek <pavel@ucw.cz> - 2017-08-29 23:20 +0200
              Re: [PATCH] DSA support for Micrel KSZ8895 Florian Fainelli <f.fainelli@gmail.com> - 2017-08-29 23:30 +0200
                Re: [PATCH] DSA support for Micrel KSZ8895 Maxim Uvarov <muvarov@gmail.com> - 2017-08-30 12:10 +0200
      Re: [PATCH] DSA support for Micrel KSZ8895 Pavel Machek <pavel@ucw.cz> - 2017-08-29 09:50 +0200
        RE: [PATCH] DSA support for Micrel KSZ8895 <Tristram.Ha@microchip.com> - 2017-08-30 23:40 +0200
          Re: [PATCH] DSA support for Micrel KSZ8895 Andrew Lunn <andrew@lunn.ch> - 2017-08-31 00:10 +0200
          Re: [PATCH] DSA support for Micrel KSZ8895 Pavel Machek <pavel@ucw.cz> - 2017-09-01 14:20 +0200
            Re: [PATCH] DSA support for Micrel KSZ8895 Florian Fainelli <f.fainelli@gmail.com> - 2017-09-02 00:20 +0200
              Re: [PATCH] DSA support for Micrel KSZ8895 Pavel Machek <pavel@ucw.cz> - 2017-09-02 17:50 +0200
          Re: [PATCH] DSA support for Micrel KSZ8895 Maxim Uvarov <muvarov@gmail.com> - 2017-09-06 11:20 +0200
            RE: [PATCH] DSA support for Micrel KSZ8895 <Tristram.Ha@microchip.com> - 2017-09-06 18:50 +0200
              Re: [PATCH] DSA support for Micrel KSZ8895 Andrew Lunn <andrew@lunn.ch> - 2017-09-06 19:10 +0200

csiph-web