Re: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page() v3

From	Jerome Glisse <jglisse@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page() v3
Date	2017-08-29 21:20 +0200
Message-ID	<ujUdk-6Et-17@gated-at.bofh.it> (permalink)
References	<ujU3E-6AB-17@gated-at.bofh.it> <ujUdj-6Et-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 29, 2017 at 12:09:45PM -0700, Linus Torvalds wrote:
> On Tue, Aug 29, 2017 at 12:05 PM, Jérôme Glisse <jglisse@redhat.com> wrote:
> > Some MMU notifier need to be able to sleep during callback. This was
> > broken by c7ab0d2fdc84 ("mm: convert try_to_unmap_one() to use
> > page_vma_mapped_walk()").
> 
> No. No no no.
> 
> Didn't you learn *anything* from the bug?
> 
> You cannot replace "mmu_notifier_invalidate_page()" with
> "mmu_notifier_invalidate_range()".
> 
> KVM implements mmu_notifier_invalidate_page().
> 
> IT DOES NOT IMPLEMENT THAT RANGE CRAP AT ALL.
> 
> So any approach like this is fundamentally garbage. Really. Stop
> sending crap. This is exactly tehe same thing that we already reverted
> because it was broken shit. Why do you re-send it without actually
> fixing the fundamental problems that were pointed out?
> 

Sorry i missed the kvm not implementing the range() only callback so
i am gonna respin with start/end.

Jérôme

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page() v3 Jérôme Glisse <jglisse@redhat.com> - 2017-08-29 21:10 +0200
  Re: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page()  v3 Jerome Glisse <jglisse@redhat.com> - 2017-08-29 21:10 +0200
  Re: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page() v3 Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-29 21:20 +0200
    Re: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page() v3 Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-29 21:20 +0200
      Re: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page() v3 Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-29 22:00 +0200
        Re: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page()  v3 Jerome Glisse <jglisse@redhat.com> - 2017-08-29 22:20 +0200
    Re: [RFC PATCH] mm/rmap: do not call mmu_notifier_invalidate_page()  v3 Jerome Glisse <jglisse@redhat.com> - 2017-08-29 21:20 +0200

csiph-web