Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1722589

Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit
Date 2017-08-29 18:10 +0200
Message-ID <ujRfs-4Ns-21@gated-at.bofh.it> (permalink)
References (7 earlier) <uizuh-3Wv-1@gated-at.bofh.it> <uiNQB-4z5-1@gated-at.bofh.it> <ujtGa-6PN-9@gated-at.bofh.it> <ujvoD-7Xb-33@gated-at.bofh.it> <ujOhC-2Kk-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Aug 29, 2017 at 5:57 AM, Liang, Kan <kan.liang@intel.com> wrote:
>>
>> Attached is an ALMOST COMPLETELY UNTESTED forward-port of those two
>> patches, now without that nasty WQ_FLAG_ARRIVALS logic, because we now
>> always put the new entries at the end of the waitqueue.
>
> The patches fix the long wait issue.
>
> Tested-by: Kan Liang <kan.liang@intel.com>

Ok. I'm not 100% comfortable applying them at rc7, so let me think
about it. There's only one known load triggering this, and by "known"
I mean "not really known" since we don't even know what the heck it
does outside of intel and whoever your customer is.

So I suspect I'll apply the patches next merge window, and we can
maybe mark them for stable if this actually ends up mattering.

Can you tell if the problem is actually hitting _production_ use or
was some kind of benchmark stress-test?

               Linus

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2 v2] sched/wait: Break up long wake list walk Tim Chen <tim.c.chen@linux.intel.com> - 2017-08-25 18:40 +0200
  [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Tim Chen <tim.c.chen@linux.intel.com> - 2017-08-25 18:40 +0200
    Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-25 22:00 +0200
      Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit Tim Chen <tim.c.chen@linux.intel.com> - 2017-08-26 00:20 +0200
        Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-26 01:10 +0200
          Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-26 02:40 +0200
            Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-26 05:00 +0200
              Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-26 20:20 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-27 23:50 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-27 23:50 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-28 01:20 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit Nicholas Piggin <npiggin@gmail.com> - 2017-08-28 03:20 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit Nicholas Piggin <npiggin@gmail.com> - 2017-08-28 03:40 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-28 07:20 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit Nicholas Piggin <npiggin@gmail.com> - 2017-08-28 09:20 +0200
                RE: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit "Liang, Kan" <kan.liang@intel.com> - 2017-08-28 17:00 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-28 18:50 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit Tim Chen <tim.c.chen@linux.intel.com> - 2017-08-28 22:10 +0200
                RE: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit "Liang, Kan" <kan.liang@intel.com> - 2017-08-29 15:00 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-29 18:10 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit Tim Chen <tim.c.chen@linux.intel.com> - 2017-08-29 18:20 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-29 18:30 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit Tim Chen <tim.c.chen@linux.intel.com> - 2017-08-29 19:00 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in  wake_up_page_bit Tim Chen <tim.c.chen@linux.intel.com> - 2017-08-29 18:20 +0200
                Re: [PATCH 2/2 v2] sched/wait: Introduce lock breaker in wake_up_page_bit Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-29 18:30 +0200
  Re: [PATCH 1/2 v2] sched/wait: Break up long wake list walk Christopher Lameter <cl@linux.com> - 2017-08-25 19:50 +0200

csiph-web