Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1722402

Re: [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST

Show all headers | View raw

* Hannes Reinecke <hare@suse.de> wrote:

> When COMPILE_TEST is set we should be compiling 32-bit only
> drivers and features (like ISA support etc), too.
> After all, it's a compile test.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
>  arch/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 781521b7cf9e..df61bc37b1a2 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2548,7 +2548,7 @@ config ISA_DMA_API
>  	  Enables ISA-style DMA support for devices requiring such controllers.
>  	  If unsure, say Y.
>  
> -if X86_32
> +if X86_32 || COMPILE_TEST
>  
>  config ISA
>  	bool "ISA support"

This is almost certainly a bad idea: if it's a compile test, why not compile test 
the 32-bit kernel, which will include these drivers?

These are drivers that have probably been ever been built in 64-bit mode, and now 
an allmodconfig/allyesconfig will turn them on...

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST Hannes Reinecke <hare@suse.de> - 2017-08-28 11:50 +0200
  Re: [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST Ingo Molnar <mingo@kernel.org> - 2017-08-29 13:50 +0200

csiph-web