Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1722388
| From | Guy Shapiro <guy.shapiro@mobi-wize.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] nvmem: core: return EFBIG on out-of-range write |
| Date | 2017-08-29 13:40 +0200 |
| Message-ID | <ujN29-229-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
When writing data that exceeds the nvmem size to a nvmem sysfs file using the sh redirection operator >, the shell hangs, trying to write the out-of-range bytes endlessly. Fix the problem by returning EFBIG described in man 2 write. Similar change was done for binary sysfs files on commit 0936896056365349afa867c16e9f9100a6707cbf Signed-off-by: Guy Shapiro <guy.shapiro@mobi-wize.com> Cc: linux-api@vger.kernel.org --- drivers/nvmem/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 4c49285..ae6cadd 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -135,7 +135,7 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, /* Stop the user from writing */ if (pos >= nvmem->size) - return 0; + return -EFBIG; if (count < nvmem->word_size) return -EINVAL; -- 2.1.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] nvmem: core: return EFBIG on out-of-range write Guy Shapiro <guy.shapiro@mobi-wize.com> - 2017-08-29 13:40 +0200
csiph-web