Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1722290
| From | Christoffer Dall <cdall@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH RFC v3 2/9] KVM: arm/arm64: fix vcpu self-detection in vgic_v3_dispatch_sgi() |
| Date | 2017-08-29 12:10 +0200 |
| Message-ID | <ujLD3-1hQ-5@gated-at.bofh.it> (permalink) |
| References | <uh1El-Dw-3@gated-at.bofh.it> <uh1Em-Dw-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Aug 21, 2017 at 10:35:23PM +0200, Radim Krčmář wrote:
> The index in kvm->vcpus array and vcpu->vcpu_id are very different
> things. Comparing struct kvm_vcpu pointers is a sure way to know.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Acked-by: Christoffer Dall <cdall@linaro.org>
> ---
> virt/kvm/arm/vgic/vgic-mmio-v3.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic-mmio-v3.c b/virt/kvm/arm/vgic/vgic-mmio-v3.c
> index 408ef06638fc..9d4b69b766ec 100644
> --- a/virt/kvm/arm/vgic/vgic-mmio-v3.c
> +++ b/virt/kvm/arm/vgic/vgic-mmio-v3.c
> @@ -797,7 +797,6 @@ void vgic_v3_dispatch_sgi(struct kvm_vcpu *vcpu, u64 reg)
> u16 target_cpus;
> u64 mpidr;
> int sgi, c;
> - int vcpu_id = vcpu->vcpu_id;
> bool broadcast;
>
> sgi = (reg & ICC_SGI1R_SGI_ID_MASK) >> ICC_SGI1R_SGI_ID_SHIFT;
> @@ -821,7 +820,7 @@ void vgic_v3_dispatch_sgi(struct kvm_vcpu *vcpu, u64 reg)
> break;
>
> /* Don't signal the calling VCPU */
> - if (broadcast && c == vcpu_id)
> + if (broadcast && c_vcpu == vcpu)
> continue;
>
> if (!broadcast) {
> --
> 2.13.3
>
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH RFC v3 2/9] KVM: arm/arm64: fix vcpu self-detection in vgic_v3_dispatch_sgi() Christoffer Dall <cdall@linaro.org> - 2017-08-29 12:10 +0200
csiph-web