Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1722203

Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode

Show all headers | View raw

Hi Marek,

2017-08-29 1:24 GMT+02:00 Marek Vasut <marek.vasut@gmail.com>:
> On 08/28/2017 11:14 PM, Marcin Wojtas wrote:
>> Hitherto code set 4B addressing mode for all SPI flashes whose
>> size exceeds 16MB. However, changing the default 3B access
>> in some cases may be harmful - it may happen that the Boot ROM
>> is not capable of handling non-default state of the SPI NOR
>> (e.g. after soft reset).
>
> No, this happens when your hardware is broken and does NOT reset the
> flash while reseting the CPU as well. If the flash is in some funny
> state (ie. middle of page program or erase cycle, which takes long OR
> 4byte addressing mode) and the CPU resets , then if the SPI NOR is not
> reset, your system will still get stuck . You need to fix your hardware
> such that you use the reset output of your CPU to detect when the CPU
> restarted and add logic to reset your storage as well.
>
> This stuff below is a poor workaround and has it's known problems which
> can only be solved by fixing the hardware. This problem keeps coming up
> repeatedly, just skim through the Linux MTD and U-Boot lists for other
> victims of bad HW design. I don't think I want to see it in the kernel
> as that would motivate people to use it rather than fixing their HW .
>

Understood. I just only got impression that attempts to overcome the
HW design faults in terms of keeping SPI NOR default state during boot
can be added - introducing SPI_NOR_4B_OPCODES seems to have no other
reason, however it favors only a group of devices that support it.

Best regards,
Marcin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode Marcin Wojtas <mw@semihalf.com> - 2017-08-28 23:20 +0200
  Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-28 23:20 +0200
    Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode Marcin Wojtas <mw@semihalf.com> - 2017-08-29 00:00 +0200
  Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing  mode Marek Vasut <marek.vasut@gmail.com> - 2017-08-29 01:30 +0200
    Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing mode Marcin Wojtas <mw@semihalf.com> - 2017-08-29 09:50 +0200
  Re: [PATCH 1/2] mtd: spi-nor: add an option to force 3byte adressing  mode Pavel Machek <pavel@ucw.cz> - 2017-09-04 18:30 +0200

csiph-web