Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1722135

Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface

Show all headers | View raw

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Mon, 28 Aug 2017 15:17:38 -0400

> This patch series adds a generic debugfs interface for the DSA
> framework, so that all switch devices benefit from it, e.g. Marvell,
> Broadcom, Microchip or any other DSA driver.

I've been thinking this over and I agree with the feedback given that
debugfs really isn't appropriate for this.

Please create a DSA device class, and hang these values under
appropriate sysfs device nodes that can be easily found via
/sys/class/dsa/ just as easily as they would be /sys/kernel/debug/dsa/

You really intend these values to be consistent across DSA devices,
and you don't intend to go willy-nilly changig these exported values
arbitrarily over time.  That's what debugfs is for, throw-away
stuff.

So please make these proper device sysfs attributes rather than
debugfs.

Thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-28 21:30 +0200
  [PATCH net-next v2 10/10] net: dsa: debugfs: add port vlan Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-28 21:30 +0200
  [PATCH net-next v2 01/10] net: dsa: add debugfs interface Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-28 21:30 +0200
    Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface Florian Fainelli <f.fainelli@gmail.com> - 2017-08-28 22:00 +0200
      Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface Jiri Pirko <jiri@resnulli.us> - 2017-08-28 22:10 +0200
    Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface Jiri Pirko <jiri@resnulli.us> - 2017-08-28 22:00 +0200
    Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface Andrew Lunn <andrew@lunn.ch> - 2017-08-28 22:20 +0200
    Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface Greg KH <gregkh@linuxfoundation.org> - 2017-09-08 07:20 +0200
      Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-08 16:10 +0200
  Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Jiri Pirko <jiri@resnulli.us> - 2017-08-28 22:00 +0200
    Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Andrew Lunn <andrew@lunn.ch> - 2017-08-28 22:10 +0200
      Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Jiri Pirko <jiri@resnulli.us> - 2017-08-29 08:30 +0200
        Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Andrew Lunn <andrew@lunn.ch> - 2017-08-29 15:00 +0200
          Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Florian Fainelli <f.fainelli@gmail.com> - 2017-08-29 21:20 +0200
            Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Andrew Lunn <andrew@lunn.ch> - 2017-08-29 22:30 +0200
          Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Jiri Pirko <jiri@resnulli.us> - 2017-08-30 09:50 +0200
  Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs  interface David Miller <davem@davemloft.net> - 2017-08-29 06:40 +0200
    Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Jiri Pirko <jiri@resnulli.us> - 2017-08-29 08:30 +0200
      Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-29 18:10 +0200
        Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface Jiri Pirko <jiri@resnulli.us> - 2017-08-30 09:50 +0200

csiph-web