Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1722072
| From | Kees Cook <keescook@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region |
| Date | 2017-08-29 02:20 +0200 |
| Message-ID | <ujCq6-3Ti-5@gated-at.bofh.it> (permalink) |
| References | <ufzTQ-1Ak-3@gated-at.bofh.it> <ufAGf-2aJ-55@gated-at.bofh.it> <ufDuq-42y-3@gated-at.bofh.it> <uhFiq-1PN-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Aug 23, 2017 at 7:56 AM, Luck, Tony <tony.luck@intel.com> wrote: >>> Should this not also have a capability check. Assuming file permissions >>> are sufficient for grabbing a chunk of system memory holding error >>> info doesn't seem too scary but it's at odds with a lot of other cases ? >> >> At least one of those other cases (pstore) added a capability check and now regret >> it. There's a thread on reverting it. Look for: >> >> Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" > > Here's at least part of that thread: > > https://marc.info/?l=linux-kernel&m=150301241114262&w=2 > > Kees: you were OK with removing the capability check from pstore, right? Yeah, as long as there is comparable protections. -Kees -- Kees Cook Pixel Security
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH] ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region Kees Cook <keescook@google.com> - 2017-08-29 02:20 +0200 Re: [PATCH] ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region "Luck, Tony" <tony.luck@intel.com> - 2017-08-29 18:00 +0200
csiph-web