Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1722086

[PATCH] storvsc: fix memory leak on ring buffer busy

Show all headers | View raw

From: Long Li <longli@microsoft.com>

When storvsc is sending I/O to Hyper-v, it may allocate a bigger buffer
descriptor for large data payload that can't fit into a pre-allocated
buffer descriptor. This bigger buffer is freed on return path.

If I/O request to Hyper-v fails due to ring buffer busy, the storvsc allocated
buffer descriptor should also be freed.

Signed-off-by: Long Li <longli@microsoft.com>
---
 drivers/scsi/storvsc_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 009adb0..db52882 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1657,6 +1657,8 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 	ret = storvsc_do_io(dev, cmd_request, smp_processor_id());
 
 	if (ret == -EAGAIN) {
+		if (payload_sz > sizeof(cmd_request->mpb))
+			kfree(payload);
 		/* no more space */
 		return SCSI_MLQUEUE_DEVICE_BUSY;
 	}
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] storvsc: fix memory leak on ring buffer busy Long Li <longli@exchange.microsoft.com> - 2017-08-29 02:50 +0200
  Re: [PATCH] storvsc: fix memory leak on ring buffer busy "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-30 03:40 +0200
    RE: [PATCH] storvsc: fix memory leak on ring buffer busy Long Li <longli@microsoft.com> - 2017-08-30 05:50 +0200
      Re: [PATCH] storvsc: fix memory leak on ring buffer busy "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-31 04:00 +0200
        RE: [PATCH] storvsc: fix memory leak on ring buffer busy Long Li <longli@microsoft.com> - 2017-08-31 04:30 +0200
    Re: [PATCH] storvsc: fix memory leak on ring buffer busy Stephen Hemminger <stephen@networkplumber.org> - 2017-08-30 17:20 +0200

csiph-web