Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720793
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 |
| Date | 2017-08-27 10:30 +0200 |
| Message-ID | <uj17c-57K-11@gated-at.bofh.it> (permalink) |
| References | <uiTMm-8mr-3@gated-at.bofh.it> <uiTMm-8mr-1@gated-at.bofh.it> <uiVbr-YP-1@gated-at.bofh.it> <uiVEt-1hA-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 27/08/2017 at 04:30:08 +0200, Andreas Färber wrote:
> Am 27.08.2017 um 04:05 schrieb Andrew Lunn:
> > n Sun, Aug 27, 2017 at 02:33:27AM +0200, Andreas Färber wrote:
> >> +struct rtd119x_rtc {
> >> + void __iomem *base;
> >> + struct clk *clk;
> >> + struct rtc_device *rtcdev;
> >> + unsigned base_year;
> >> + spinlock_t lock;
> >
> > Where is this lock initialised? I would expect a call to
> > spin_lock_init() somewhere.
>
> Hm, the spinlock in my irq mux series doesn't have that call either; my
> reset driver did have it. The zero initialization appears to work OK,
> but you're probably right that it should be there.
>
> > I also wonder what this lock is protecting, which rtc->ops_lock does
> > not protect?
>
> By that same argument we could ask why so many drivers (and mine, too)
> are calling rtc_valid_tm() when __rtc_read_time() calls it again...
>
Most of them probably predates the introduction of the check in
__rtc_read_time().
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 2/3] rtc: Add Realtek RTD1295 Andreas Färber <afaerber@suse.de> - 2017-08-27 02:40 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Andrew Lunn <andrew@lunn.ch> - 2017-08-27 04:10 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Andreas Färber <afaerber@suse.de> - 2017-08-27 04:40 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Andrew Lunn <andrew@lunn.ch> - 2017-08-27 05:30 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Andreas Färber <afaerber@suse.de> - 2017-08-27 12:30 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-27 10:30 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Andreas Färber <afaerber@suse.de> - 2017-08-27 12:30 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-27 11:20 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Andreas Färber <afaerber@suse.de> - 2017-08-27 13:40 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Andrew Lunn <andrew@lunn.ch> - 2017-08-27 15:40 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-27 21:30 +0200
Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-28 18:00 +0200
csiph-web