Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720510

Re: [PATCH 3.16 119/134] ipv4: restore rt->fi for reference counting

From Ben Hutchings <ben@decadent.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 3.16 119/134] ipv4: restore rt->fi for reference counting
Date 2017-08-26 02:40 +0200
Message-ID <uixiO-2At-5@gated-at.bofh.it> (permalink)
References <ufPlT-4d0-3@gated-at.bofh.it> <ufPlT-4d0-7@gated-at.bofh.it> <ufPYC-4vA-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, 2017-08-18 at 06:53 -0700, Eric Dumazet wrote:
> > On Fri, Aug 18, 2017 at 6:13 AM, Ben Hutchings <ben@decadent.org.uk> wrote:
> > 3.16.47-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: WANG Cong <xiyou.wangcong@gmail.com>
> > 
> > commit 82486aa6f1b9bc8145e6d0fa2bc0b44307f3b875 upstream.
[...]
> I thought we refined this later with :

In fact it was reverted upstream, then replaced by the commits you
point out.  Thanks; I don't know why I missed that.

> commit 3fb07daff8e99243366a081e5129560734de4ada
> Author: Eric Dumazet <edumazet@google.com>
> Date:   Thu May 25 14:27:35 2017 -0700
> 
>     ipv4: add reference counting to metrics
[...]

It's not obvious how to backport this, as it adds:

+#define DST_METRICS_REFCOUNTED		0x2UL

but 3.16 already has a flag with value 2.  I don't think we can take
another bit from the pointer as metrics are only 32-bit aligned.

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that there are so many of
them.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 3.16 119/134] ipv4: restore rt->fi for reference counting Ben Hutchings <ben@decadent.org.uk> - 2017-08-26 02:40 +0200

csiph-web