Groups > linux.kernel > #1720473

Re: [PATCH] x86: use KERN_CONT in dump_pagetable()

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86: use KERN_CONT in dump_pagetable()
Date	2017-08-26 00:10 +0200
Message-ID	<uiuXE-1gP-11@gated-at.bofh.it> (permalink)
References	<uhWMi-4E5-9@gated-at.bofh.it> <uhWMi-4E5-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 24 Aug 2017, Jan Beulich wrote:

> The lack of newlines in preceding format strings is a clear indication
> that these were meant to be continuations of one another, and indeed
> output ends up quite a bit more compact (and readable) that way.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
>  arch/x86/mm/fault.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> --- 4.13-rc6/arch/x86/mm/fault.c
> +++ 4.13-rc6-x86-dumppgt-cont/arch/x86/mm/fault.c
> @@ -415,9 +415,9 @@ static void dump_pagetable(unsigned long
>  		goto out;
>  
>  	pte = pte_offset_kernel(pmd, address);
> -	printk("*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte));
> +	printk(KERN_CONT "*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte));

Can you please make that pr_cont() while at it and change the pure
printk()s in that function to pr_info()?

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] x86: use KERN_CONT in dump_pagetable() "Jan Beulich" <JBeulich@suse.com> - 2017-08-24 11:40 +0200
  Re: [PATCH] x86: use KERN_CONT in dump_pagetable() Thomas Gleixner <tglx@linutronix.de> - 2017-08-26 00:10 +0200

csiph-web