Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720399

Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting

Show all headers | View raw

On 25 August 2017 at 08:37, Luca Abeni <luca.abeni@santannapisa.it> wrote:
> Hi Mathieu,
>
> On Wed, 23 Aug 2017 13:47:13 -0600
> Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
>
>> On 22 August 2017 at 06:21, Luca Abeni <luca.abeni@santannapisa.it> wrote:
>> > Hi Mathieu,
>>
>> Good day to you,
>>
>> >
>> > On Wed, 16 Aug 2017 15:20:36 -0600
>> > Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
>> >
>> >> This is a renewed attempt at fixing a problem reported by Steve Rostedt [1]
>> >> where DL bandwidth accounting is not recomputed after CPUset and CPUhotplug
>> >> operations.  When CPUhotplug and some CUPset manipulation take place root
>> >> domains are destroyed and new ones created, loosing at the same time DL
>> >> accounting pertaining to utilisation.
>> >
>> > Thanks for looking at this longstanding issue! I am just back from
>> > vacations; in the next days I'll try your patches.
>> > Do you have some kind of scripts for reproducing the issue
>> > automatically? (I see that in the original email Steven described how
>> > to reproduce it manually; I just wonder if anyone already scripted the
>> > test).
>>
>> I didn't bother scripting it since it is so easy to do.  I'm eager to
>> see how things work out on your end.
>
> I ran some tests with your patchset, and I confirm that it fixes the
> issue originally pointed out by Steven.
>

Good, at least it's a start.

> But I still need to run some more tests (I'll continue on Monday).
>
> I think I found an issue by:
> 1) creating two disjoint cpusets (CPUs 0 and 1 in the first cpuset,
>    CPUs 2 and 3 in the second one) and setting sched_load_balance to 0
> 2) starting a task in one of the two cpusets, and making it
>    SCHED_DEADLINE <--- up to here, everything looks fine
> 3) setting sched_load_balance to 1 <--- At this point, I think there is
>    a bug: the system has only one root domain, and the task utilization
>    is summed to it... But the task affinity mask is still the one of
>    the "old root domain" that was associated with the cpuset where the
>    task is executing.

I can reproduce the problem on my side as well.

This is how CPUset works and the expected behaviour.  For normal tasks
it isn't a problem but I agree with you that for DL tasks, we need to
address this.

>
> I still need to run some experiments about this.

Thanks for the time,
Mathieu

>
>
>
>                                 Thanks,
>                                         Luca

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting  Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-08-16 23:30 +0200
  [PATCH 5/7] cgroup: Concentrate DL related validation code in one place Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-08-16 23:30 +0200
  Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Luca Abeni <luca.abeni@santannapisa.it> - 2017-08-22 14:30 +0200
    Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-08-23 21:50 +0200
      Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Luca Abeni <luca.abeni@santannapisa.it> - 2017-08-24 10:00 +0200
        Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Juri Lelli <juri.lelli@arm.com> - 2017-08-24 10:40 +0200
        Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-08-24 22:40 +0200
          Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting luca abeni <luca.abeni@santannapisa.it> - 2017-08-25 08:10 +0200
            Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Luca Abeni <luca.abeni@santannapisa.it> - 2017-08-25 12:00 +0200
              Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-08-25 22:00 +0200
              Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-08-25 22:40 +0200
      Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Luca Abeni <luca.abeni@santannapisa.it> - 2017-08-25 16:40 +0200
        Re: [PATCH 0/7] sched/deadline: fix cpusets bandwidth accounting Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-08-25 22:30 +0200

csiph-web