Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720193

Re: [PATCH] OF: move extern declarations of entry pointers inside ifdef

Show all headers | View raw

On Fri, 25 Aug 2017 15:20:12 +0000
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> wrote:

> On Fri, 2017-08-25 at 11:12 -0400, Steven Rostedt wrote:
> > On Fri, 25 Aug 2017 18:00:26 +0300
> > Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> wrote:
> >   
> > > Move extern declarations of "of_root", "of_chosen", "of_aliases",
> > > "of_stdout" pointers inside "CONFIG_OF" ifdef to be able to get rid
> > > of "CONFIG_OF" ifdef in their usage places.
> > > 
> > > Suggested-by: Steven Rostedt <rostedt@goodmis.org>  
> > 
> > Thanks!
> > -- Steve  
> 
> Could you please ACK my patch if it looks good for you?
> Thanks.

I could, but ACKs are usually for the maintainer of the code being
changed. I don't maintain include/linux/of.h

But for what it's worth...

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] OF: move extern declarations of entry pointers inside ifdef Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-08-25 17:10 +0200
  Re: [PATCH] OF: move extern declarations of entry pointers inside  ifdef Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:20 +0200
    Re: [PATCH] OF: move extern declarations of entry pointers inside  ifdef Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-08-25 17:30 +0200
      Re: [PATCH] OF: move extern declarations of entry pointers inside  ifdef Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:30 +0200
  Re: [PATCH] OF: move extern declarations of entry pointers inside ifdef Rob Herring <robh@kernel.org> - 2017-08-25 17:50 +0200

csiph-web