Groups > linux.kernel > #1720126

Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

Path	csiph.com!aioe.org!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Stefan Schmidt <stefan@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const
Date	Fri, 25 Aug 2017 16:40:03 +0200
Message-ID	<uinWb-5dr-31@gated-at.bofh.it> (permalink)
References	<uinMt-5ah-1@gated-at.bofh.it> <uinMu-5ah-35@gated-at.bofh.it>
X-Original-To	Bhumika Goyal <bhumirks@gmail.com>, julia.lawall@lip6.fr, marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, davem@davemloft.net, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, stephen@networkplumber.org, alex.aring@gmail.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, santosh.shilimkar@oracle.com, trond.myklebust@primarydata.com, anna.schumaker@netapp.com, bfields@fieldses.org, jlayton@poochiereds.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, linux-wpan@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Language	en-US
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Date	Fri, 25 Aug 2017 16:36:37 +0200
X-Original-Message-ID	<c9ada435-af29-c5e0-b72d-374199f6b6f9@osg.samsung.com>
X-Original-References	<1503670907-23221-1-git-send-email-bhumirks@gmail.com> <1503670907-23221-4-git-send-email-bhumirks@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1720126

Show key headers only | View raw

Hello.

On 08/25/2017 04:21 PM, Bhumika Goyal wrote:
> Make this const as it is only stored as a reference in a const field of
> a net_device structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>   net/ieee802154/6lowpan/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> index de2661c..974765b 100644
> --- a/net/ieee802154/6lowpan/core.c
> +++ b/net/ieee802154/6lowpan/core.c
> @@ -54,7 +54,7 @@
>   
>   static int open_count;
>   
> -static struct header_ops lowpan_header_ops = {
> +static const struct header_ops lowpan_header_ops = {
>   	.create	= lowpan_header_create,
>   };
>   
> 

Acked-by: Stefan Schmidt <stefan@osg.samsung.com>

regards
Stefan Schmidt

Thread

[PATCH 0/7] net: make some structures const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
  [PATCH 2/7] bridge: make ebt_table const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
    Re: [PATCH 2/7] bridge: make ebt_table const David Miller <davem@davemloft.net> - 2017-08-28 20:40 +0200
  [PATCH 7/7] SUNRPC: make kvec const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
    Re: [PATCH 7/7] SUNRPC: make kvec const Jeff Layton <jlayton@redhat.com> - 2017-08-25 16:50 +0200
  [PATCH 5/7] RDS: make rhashtable_params const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
    Re: [PATCH 5/7] RDS: make rhashtable_params const Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-08-25 17:40 +0200
    Re: [PATCH 5/7] RDS: make rhashtable_params const David Miller <davem@davemloft.net> - 2017-08-28 20:40 +0200
  [PATCH 6/7] netfilter: nat: make rhashtable_params const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
  [PATCH 1/7] Bluetooth: 6lowpan: make header_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
  [PATCH 3/7] ieee802154: 6lowpan: make header_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
    Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const Stefan Schmidt <stefan@osg.samsung.com> - 2017-08-25 16:40 +0200
    Re: [PATCH 3/7] ieee802154: 6lowpan: make header_ops const Marcel Holtmann <marcel@holtmann.org> - 2017-08-25 18:20 +0200
  [PATCH 4/7] ipv4: make net_protocol const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-25 16:30 +0200
    Re: [PATCH 4/7] ipv4: make net_protocol const David Miller <davem@davemloft.net> - 2017-08-28 20:40 +0200

csiph-web