Groups > linux.kernel > #1720123

[PATCH v4 06/10] drivers base/arch_topology: allow inlining cpu-invariant accounting support

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Dietmar Eggemann <dietmar.eggemann@arm.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 06/10] drivers base/arch_topology: allow inlining cpu-invariant accounting support
Date	Fri, 25 Aug 2017 16:40:03 +0200
Message-ID	<uinWb-5dr-29@gated-at.bofh.it> (permalink)
References	<uinW9-5dr-3@gated-at.bofh.it>
X-Original-To	linux-kernel@vger.kernel.org
X-Mailer	git-send-email 2.11.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	linux-pm@vger.kernel.org, linux@arm.linux.org.uk, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Juri Lelli <juri.lelli@arm.com>, Vincent Guittot <vincent.guittot@linaro.org>, Peter Zijlstra <peterz@infradead.org>, Morten Rasmussen <morten.rasmussen@arm.com>, Viresh Kumar <viresh.kumar@linaro.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Sudeep Holla <sudeep.holla@arm.com>
X-Original-Date	Fri, 25 Aug 2017 15:32:02 +0100
X-Original-Message-ID	<20170825143206.30467-7-dietmar.eggemann@arm.com>
X-Original-References	<20170825143206.30467-1-dietmar.eggemann@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1720123

Show key headers only | View raw

Allow inlining of topology_get_cpu_scale() into the task
scheduler fast path (e.g. __update_load_avg_se()) by coding it as a
static inline function in the arch topology header file.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Juri Lelli <juri.lelli@arm.com>
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/base/arch_topology.c  | 7 +------
 include/linux/arch_topology.h | 8 +++++++-
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index af9ab98a233e..c8cd92ba4cc0 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -37,12 +37,7 @@ void arch_set_freq_scale(struct cpumask *cpus, unsigned long cur_freq,
 }
 
 static DEFINE_MUTEX(cpu_scale_mutex);
-static DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE;
-
-unsigned long topology_get_cpu_scale(struct sched_domain *sd, int cpu)
-{
-	return per_cpu(cpu_scale, cpu);
-}
+DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE;
 
 void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity)
 {
diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
index 3e3c2657c9a1..0c4e43d6a3bb 100644
--- a/include/linux/arch_topology.h
+++ b/include/linux/arch_topology.h
@@ -11,8 +11,14 @@ void topology_normalize_cpu_scale(void);
 struct device_node;
 int topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu);
 
+DECLARE_PER_CPU(unsigned long, cpu_scale);
+
 struct sched_domain;
-unsigned long topology_get_cpu_scale(struct sched_domain *sd, int cpu);
+static inline
+unsigned long topology_get_cpu_scale(struct sched_domain *sd, int cpu)
+{
+	return per_cpu(cpu_scale, cpu);
+}
 
 void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity);
 
-- 
2.11.0

Thread

[PATCH v4 00/10] arm, arm64, cpufreq: frequency- and cpu-invariant accounting support for task scheduler Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-25 16:40 +0200
  [PATCH v4 06/10] drivers base/arch_topology: allow inlining cpu-invariant accounting support Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-25 16:40 +0200
  [PATCH v4 09/10] arm64: wire frequency-invariant accounting support up to the task scheduler Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-25 16:40 +0200
  [PATCH v4 10/10] arm64: wire cpu-invariant accounting support up to the task scheduler Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-25 16:40 +0200
  [PATCH v4 05/10] drivers base/arch_topology: provide frequency-invariant accounting support Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-25 16:40 +0200
  [PATCH v4 03/10] cpufreq: arm_big_little: invoke frequency-invariance setter function Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-25 16:40 +0200
  [PATCH v4 07/10] arm: wire frequency-invariant accounting support up to the task scheduler Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-25 16:40 +0200
  [PATCH v4 02/10] cpufreq: provide default frequency-invariance setter function Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-25 16:40 +0200
    Re: [PATCH v4 02/10] cpufreq: provide default frequency-invariance setter function "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-09-08 01:40 +0200
  Re: [PATCH v4 00/10] arm, arm64, cpufreq: frequency- and cpu-invariant accounting support for task scheduler "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-31 01:50 +0200
    Re: [PATCH v4 00/10] arm, arm64, cpufreq: frequency- and  cpu-invariant accounting support for task scheduler Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-31 13:30 +0200
      Re: [PATCH v4 00/10] arm, arm64, cpufreq: frequency- and  cpu-invariant accounting support for task scheduler Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-09-07 14:10 +0200

csiph-web