Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720113

Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Tom Rini <trini@konsulko.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
Date Fri, 25 Aug 2017 16:30:02 +0200
Message-ID <uinMu-5ah-37@gated-at.bofh.it> (permalink)
References <uht7A-2oU-33@gated-at.bofh.it> <uinjr-4Jl-1@gated-at.bofh.it>
X-Original-To Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OyeHhcpQ/xSGjSIHvc9N8+GbFz0uHoWiZEkhhSrjp0s=; b=WbftydA6Cu2pr3hATep6T+y38mBlG5QqUt5Gb/OY9U070L4Csxttl6diwhxv2NUk88 t0ed6GMYG7mQodgTUMIvoeyZacycIBJIjHCTdY2FZU6/aA62EsJEsxKcKMOKTSX5XPU1 iJ71S6bRK6LWlSuhFuak/+OjdoqmD0mx18qqY=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OyeHhcpQ/xSGjSIHvc9N8+GbFz0uHoWiZEkhhSrjp0s=; b=reYPg+sfXDYtqMiqjVDpsJS9XOekWqpplypBsqG5UWrdU5PZn5DwNpsJHbu4z0DNaZ iXJJVUtymxcScSxkzjVZID0N5qSj8HrBevok0Oe+MWnveSjtrx/BFX4pjCMzS9/ofdDu 0OYVZ8YmW10eqNJM3AG1C2a6IefB3esuHBofXLouemBD4doSAx5GnYZ7+AAUBuF5iUSV eqCFFG8DES39yG733OD0DPn9ipSXOnH4uhZE5fL5bDt5rR7f15T3Ai+mPYWi0lRKp7cm jqSlSxQZnF4FnBFJijHXZ9W4M9SH6/8GzCoKJ8hGXB/GjUShAHUgg2pC/+MK94fgd8Kr JA3g==
X-Gm-Message-State AHYfb5j9QxfHEVMzryYKjpa9qnyzZWdLitXSgzGG8RlATCOxXx2L4N1/ 3b3KbvkWDN/B7Yn3
X-Received by 10.129.162.7 with SMTP id z7mr8846711ywg.202.1503671054275; Fri, 25 Aug 2017 07:24:14 -0700 (PDT)
MIME-Version 1.0
Content-Type multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="i6vqABX3nJKXLk01"
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 72
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, John Keeping <john@metanate.com>, Bard Liao <bardliao@realtek.com>, Oder Chiou <oder_chiou@realtek.com>, Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>
X-Original-Date Fri, 25 Aug 2017 10:24:26 -0400
X-Original-Message-ID <20170825142426.GN2827@bill-the-cat>
X-Original-References <1503453106-5564-1-git-send-email-trini@konsulko.com> <1503669407.25945.102.camel@linux.intel.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1720113

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, Aug 25, 2017 at 04:56:47PM +0300, Andy Shevchenko wrote:
> +John
> 
> On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > Not all devices with ACPI and this combination of sound devices will
> > have the required information provided via ACPI.  Reintroduce the I2C
> > device ID to restore sound functionality on on the Chromebook 'Samus'
> > model.
> 
> Tom, one more question.
> 
> Apparently you are the one who tested the commit
> 	89128534f925 ("ASoC: rt5677: Add ACPI support")
> year ago.

Yes.

> The commit states that ACPI properties that are used in Chromebook Pixel
> 2015 is non-standard (not the same as for DT).
> 
> However, DSDT shows the opposite!

Interesting.  I'm not an ACPI person, I just tested what John came up
with.

> I would like to ask yuo and John what is the status of that currently?
> Do we have any publicly available laptop with non-standard properties?

Is there any sort of "build date" or similar in the dump I provided
yesterday?  Every once in a while my laptop accidentally books into
ChromeOS and then it might grab and apply some updates and it's not
impossible that Google updated things in the interim.

I'm quite happy to test patches or provide further dumps / etc from my
system.  You might want to start by talking with the person behind
https://github.com/raphael/linux-samus to see if they know more about
different versions of the hardware or at least point you towards more
testers.  Thanks!

-- 
Tom

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-23 04:00 +0200
  Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Mark Brown <broonie@kernel.org> - 2017-08-23 11:30 +0200
    Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-24 00:40 +0200
      Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Mark Brown <broonie@kernel.org> - 2017-08-24 00:50 +0200
        Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-24 01:00 +0200
          Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Mark Brown <broonie@kernel.org> - 2017-08-24 01:20 +0200
        Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Mark Brown <broonie@kernel.org> - 2017-08-24 01:10 +0200
  Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-23 16:40 +0200
    Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-23 19:40 +0200
      Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-24 02:10 +0200
        Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-24 09:50 +0200
          Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-24 13:20 +0200
            Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-24 14:40 +0200
              Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-24 15:50 +0200
              Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Mark Brown <broonie@kernel.org> - 2017-08-24 15:50 +0200
        Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Takashi Iwai <tiwai@suse.de> - 2017-08-24 16:30 +0200
          Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Takashi Iwai <tiwai@suse.de> - 2017-08-24 16:40 +0200
            Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-24 16:50 +0200
              Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Takashi Iwai <tiwai@suse.de> - 2017-08-24 17:50 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Mark Brown <broonie@kernel.org> - 2017-08-24 18:00 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-24 18:00 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Takashi Iwai <tiwai@suse.de> - 2017-08-24 18:10 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-24 18:10 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-24 19:20 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Takashi Iwai <tiwai@suse.de> - 2017-08-24 19:50 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Mark Brown <broonie@kernel.org> - 2017-08-25 15:50 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Mark Brown <broonie@kernel.org> - 2017-08-25 15:20 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Takashi Iwai <tiwai@suse.de> - 2017-08-25 15:20 +0200
                Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Takashi Iwai <tiwai@suse.de> - 2017-08-24 18:00 +0200
  Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-25 16:00 +0200
    Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-25 16:30 +0200
      Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-25 16:50 +0200
      Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs John Keeping <john@metanate.com> - 2017-08-25 18:40 +0200
        Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-25 18:50 +0200
          Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs John Keeping <john@metanate.com> - 2017-08-25 19:10 +0200
          Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini <trini@konsulko.com> - 2017-08-25 21:40 +0200

csiph-web