Groups > linux.kernel > #1720106

Re: [PATCH] trace-cmd report: Fix hash.key in option -w

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] trace-cmd report: Fix hash.key in option -w
Date	2017-08-25 16:30 +0200
Message-ID	<uinMt-5ah-9@gated-at.bofh.it> (permalink)
References	<uifFg-8sr-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 25 Aug 2017 13:47:49 +0800
"Ziqian SUN (Zamir)" <zsun@redhat.com> wrote:

> From: "Ziqian SUN (Zamir)" <zsun@redhat.com>
> 
> In add_wakeup function the hash list is created with hash.key = value.
> This makes add_sched function will never find a match with the key which
> results in trace-cmd report will never show the average latency with the
> following command:
> trace-cmd report -w -F 'sched_switch,sched_wakeup'
> With this patch, the command will show average latency as it used to be
> in v2.4.2 like
> 
> Average wakeup latency: 28.460 usecs
> Maximum Latency: 669.268 usecs at timestamp: 16337.629767
> Minimum Latency: 2.153 usecs at timestamp: 16337.533735
> 
> RT task timings:
> 
> Average wakeup latency: 23.106 usecs
> Maximum Latency: 57.482 usecs at timestamp: 16337.187531
> Minimum Latency: 4.127 usecs at timestamp: 16336.945209
> 
> Reported-by: Joe Mario <jmario@redhat.com>
> Signed-off-by: Ziqian SUN (Zamir) <zsun@redhat.com>

Thanks a lot Ziqian! Added. Will push out soon.

I need to update the stables too.

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] trace-cmd report: Fix hash.key in option -w "Ziqian SUN (Zamir)" <zsun@redhat.com> - 2017-08-25 07:50 +0200
  Re: [PATCH] trace-cmd report: Fix hash.key in option -w Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 16:30 +0200

csiph-web